Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a code formatter for the smalltalk part #15

Open
MichaelBuessemeyer opened this issue Jan 21, 2022 · 3 comments
Open

Consider a code formatter for the smalltalk part #15

MichaelBuessemeyer opened this issue Jan 21, 2022 · 3 comments

Comments

@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Jan 21, 2022

Hi @cmfcmf,

I have been working with your awesome project for some weeks now. I can see that some functions are not formatted perfectly (which is a very personal opinion). Thus I used formatter for Squeak by @tom95 to format the code. This would have the benefit of consistent formatted code, could clean up my mess and could lead to lesser merge conflicts :)

Here is the code formatter: https://github.com/hpi-swa-teaching/poppy-print

Do you think it would be a nice addition to this project? If yes, I'd like to open a PR for that. But I don't know how to add a package dependency to the project 🤷 . Could you please me out here in that case?

@tom95
Copy link
Collaborator

tom95 commented Jan 22, 2022

Hi @MichaelBuessemeyer! poppy-print currently doesn't have support to be integrated as part of a toolchain in the same way e.g. prettier in JS does. If @cmfcmf is fine with this, the current workflow would likely be:

  • create a PR with all code autoformatted
  • update the README/CONTRIBUTING with instructions on how to reformat code before committing using poppy-print

@cmfcmf
Copy link
Owner

cmfcmf commented Jan 22, 2022

  • create a PR with all code autoformatted
  • update the README/CONTRIBUTING with instructions on how to reformat code before committing using poppy-print

Sounds good to me!

@MichaelBuessemeyer
Copy link
Contributor Author

Sounds good to me!

Alrighty 👯, here it is: #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants