Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 [Bug Report] Past commit left stale code in classic and wotlk repository #3695

Open
orygg opened this issue Apr 7, 2024 · 0 comments
Open

馃悰 [Bug Report] Past commit left stale code in classic and wotlk repository #3695

orygg opened this issue Apr 7, 2024 · 0 comments
Labels
Info: Needs Replication Issue needs replication before further action.

Comments

@orygg
Copy link

orygg commented Apr 7, 2024

Bug Details

Commits
cmangos/mangos-classic@0da1a50 and
cmangos/mangos-wotlk@cb1444f
did not remove Socket.cpp like the tbc commit, cmangos/mangos-tbc@a0b44d1, did.

Steps to Reproduce

  1. Look at the linked commits and observe the difference.

Expected behavior

Files should have been deleted.

Suggested Workaround

Non necessary

Crash Log

No response

Core SHA1 Commit Hash

10b7680bf5827a53da03f40a5e00032a0a86700f

Database SHA1 Commit Hash

10b7680bf5827a53da03f40a5e00032a0a86700f

Operating System

all

Client Version

1.12.1 (Classic)
@orygg orygg added the Info: Needs Replication Issue needs replication before further action. label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Info: Needs Replication Issue needs replication before further action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orygg