Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [Feature Request] Explicit SELECT statements #3690

Closed
3 tasks done
insunaa opened this issue Apr 2, 2024 · 1 comment
Closed
3 tasks done

馃殌 [Feature Request] Explicit SELECT statements #3690

insunaa opened this issue Apr 2, 2024 · 1 comment
Labels
Type: Feature Request Issue is a CMaNGOS Extensions request.

Comments

@insunaa
Copy link
Contributor

insunaa commented Apr 2, 2024

Feature Details

Use explicit SELECT statements in source to replace SELECT * FROM queries.

Visualizations

No response

Benefits and Purpose

If DB tables are ever re-arranged we don't have to worry about suddenly getting nonsense from some hard-coded SQL queries

Core Versions

  • 1.1.12 (Classic)
  • 2.4.3 (The Burning Crusade)
  • 3.3.5a (Wrath of the Lich King)
@insunaa insunaa added the Type: Feature Request Issue is a CMaNGOS Extensions request. label Apr 2, 2024
@insunaa
Copy link
Contributor Author

insunaa commented Apr 2, 2024

Mainly opened this as a discussion/question. Should we allow SELECT * FROM queries in code or should we always explicitly SELECT explicitly named columns? We currently have 9 occurrences of SELECT * FROM in our code, a few more if we count the deprecated playerbots

@insunaa insunaa closed this as completed Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request Issue is a CMaNGOS Extensions request.
Projects
None yet
Development

No branches or pull requests

1 participant