Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [Bug Report] Page_texts missing formatting #3688

Open
cpevors opened this issue Apr 1, 2024 · 4 comments
Open

馃悰 [Bug Report] Page_texts missing formatting #3688

cpevors opened this issue Apr 1, 2024 · 4 comments
Labels
Info: Needs Replication Issue needs replication before further action.

Comments

@cpevors
Copy link

cpevors commented Apr 1, 2024

Bug Details

I am leveling a new character, so this will likely get updated as I go along, but there are various page_texts that are missing applicable formatting, chiefly line breaks. I was informed that these page_texts are exclusively derived from sniffs, so I cannot make a quick PR to fix them. Might you consult the sniffs?

  1. Maybell's Love Letter (https://www.wowhead.com/classic/item=1208/maybells-love-letter)
    image

  2. Gramma Stonefield's Note, page 2 (https://www.wowhead.com/classic/item=1252/gramma-stonefields-note)
    image

  3. Cloth Request (https://www.wowhead.com/classic/item=2724/cloth-request)
    image

  4. Lewis' Note (https://www.wowhead.com/classic/item=15998/lewis-note)
    image

Steps to Reproduce

These items are placed in our inventories upon accepting the applicable quests:

  1. Maybell's Letter is provided when accepting Young Lovers (https://www.wowhead.com/classic/quest=106/young-lovers)
  2. Gramma Stonefield's Note is provided when accepting Note to William (https://www.wowhead.com/classic/quest=107/note-to-william)
  3. Cloth Request is provided when accepting Harlan Needs a Resupply (https://www.wowhead.com/classic/quest=333/harlan-needs-a-resupply)
  4. Lewis' Note is provided when accepting A Swift Message (https://www.wowhead.com/classic/quest=6181/a-swift-message)

Expected behavior

I know this is nitpicky, but there should be various line breaks in all of these page_texts. In some cases, there are none, and the page_texts are pretty garbled.

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

3bf443a39217fc33af958f3d66dd9b2e162ad895

Database SHA1 Commit Hash

f61dac574dade175908df078bbe2c47bfaee3d21

Operating System

Windows 11 Home - 64-bit

Client Version

2.4.3 (The Burning Crusade)

@cpevors cpevors added the Info: Needs Replication Issue needs replication before further action. label Apr 1, 2024
@cpevors
Copy link
Author

cpevors commented Apr 1, 2024

  1. Wiley's Note, page 1 (https://www.wowhead.com/classic/item=1327/wileys-note)
    image
    Provided when accepting The Defias Brotherhood (https://www.wowhead.com/classic/quest=132/the-defias-brotherhood)

  2. Shaw's Report, page 1 [should be a line break after --] (https://www.wowhead.com/classic/item=1353/shaws-report)
    image
    Provided when accepting The Defias Brotherhood (https://www.wowhead.com/classic/quest=141/the-defias-brotherhood)

  3. Solomon's Plea to Westfall (https://www.wowhead.com/classic/item=1407/solomons-plea-to-westfall)
    image
    Provided when accepting Messenger to Westfall (https://www.wowhead.com/classic/quest=143/messenger-to-westfall)

@cpevors
Copy link
Author

cpevors commented Apr 2, 2024

  1. A Mysterious Message (https://www.wowhead.com/tbc/item=1381/a-mysterious-message)
    image
    Dropped from Defias Messenger while on The Defias Brotherhood (https://www.wowhead.com/tbc/quest=142/the-defias-brotherhood)

@cpevors
Copy link
Author

cpevors commented Apr 2, 2024

  1. Solomon's Plea to Darkshire (https://www.wowhead.com/tbc/item=1409/solomons-plea-to-darkshire)
    image
    Provided when accepting Messenger to Darkshire (https://www.wowhead.com/tbc/quest=145/messenger-to-darkshire)

@cpevors
Copy link
Author

cpevors commented Apr 4, 2024

  1. Calor's Note (https://www.wowhead.com/tbc/item=2113/calors-note)
    image
    Provided when accepting the quest Worgen in the Woods (https://www.wowhead.com/tbc/quest=223/worgen-in-the-woods)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info: Needs Replication Issue needs replication before further action.
Projects
None yet
Development

No branches or pull requests

1 participant