Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initializeDynet transparently #132

Open
MihaiSurdeanu opened this issue May 9, 2022 · 3 comments
Open

initializeDynet transparently #132

MihaiSurdeanu opened this issue May 9, 2022 · 3 comments
Assignees

Comments

@MihaiSurdeanu
Copy link
Contributor

Call initializeDynet in the c'tor for CluProcessor rather than explicitly in the code.

@kwalcock
Copy link
Member

kwalcock commented Nov 22, 2022

Processors has a PR to do this. However, to use it with habitus, processors would normally need to be republished. There are some other habitus-related changes to processors that probably aren't ready to publish without a little more real-life testing, mostly because unpublishing is next to impossible. I'm thinking of the Odin-related bug fix in particular #673. I would like to modify habitus to use the main, not yet published branch of processors to get in more testing before publishing. Habitus is the project that is most able to observe problems that might arise. So, I would go ahead and merge PRs to processors and then modify habitus to use the changes, but hold off on the publishing. This would be achieved by having habitus use the jitpack resolver ("jitpack" at "https://jitpack.io") as done in other projects. FYI @MihaiSurdeanu, @maxaalexeeva.

@MihaiSurdeanu
Copy link
Contributor Author

Makes sense. Also, habitus people can just publishLocal for now.

@kwalcock
Copy link
Member

jitpack seems unable to build processors. I will try artifactory instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants