Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for packages locally #33

Closed
nkbt opened this issue Aug 15, 2015 · 4 comments
Closed

Search for packages locally #33

nkbt opened this issue Aug 15, 2015 · 4 comments
Assignees

Comments

@nkbt
Copy link
Contributor

nkbt commented Aug 15, 2015

At the moment Cloverfield searches for globally installed packages. We need to search for locally installed as well.

@ericelliott
Copy link
Contributor

👍

@nkbt nkbt self-assigned this Aug 18, 2015
@nkbt
Copy link
Contributor Author

nkbt commented Aug 25, 2015

After some code written and some additional thoughts, I believe for cloverfield we should stick to locally installed modules exclusively. And if necessary install missing scaffolds on-demand [#17].

Technically it would simplify the code a little bit - I would be able to do simple require(package.name) and then run it. Without any additional parsing of package.json.

But what is more important, it would be conceptually more correct - whatever cloverfield is working with is only stored locally, so it does not try to go beyond its own folder.

I will still make a PR with what is done, and we can update it later.

@nkbt
Copy link
Contributor Author

nkbt commented Aug 25, 2015

See #34. It works fine for now, but I would think about removing findGlobal (not 100% sure on that though)

ericelliott pushed a commit that referenced this issue Sep 1, 2015
[#33] Search for packages locally
@ericelliott
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants