Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen.py does not support properties that are List and have no Resources #1751

Open
mparaz opened this issue Jul 23, 2020 · 0 comments
Open

gen.py does not support properties that are List and have no Resources #1751

mparaz opened this issue Jul 23, 2020 · 0 comments

Comments

@mparaz
Copy link

mparaz commented Jul 23, 2020

I can try fixing it, I just need some guidance.

For example:

    "AWS::LakeFormation::DataLakeSettings.Admins": {
      "Type": "List",
      "Required": false,
      "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lakeformation-datalakesettings-admins.html",
      "ItemType": "DataLakePrincipal",
      "UpdateType": "Mutable"
    }

    "AWS::LakeFormation::DataLakeSettings": {
      "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lakeformation-datalakesettings.html",
      "Properties": {
        "Admins": {
          "Type": "Admins",
          "Required": false,
          "Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lakeformation-datalakesettings.html#cfn-lakeformation-datalakesettings-admins",
          "UpdateType": "Mutable"
        }
      }
    },

Has the output:

class Admins(AWSProperty):
    props = {
    }

class DataLakeSettings(AWSObject):
    resource_type = "AWS::LakeFormation::DataLakeSettings"

    props = {
        'Admins': (Admins, False),
    }

When I think it should be:

class DataLakeSettings(AWSObject):
    resource_type = "AWS::LakeFormation::DataLakeSettings"

    props = {
        'Admins': ([DataLakePrincipal], False),
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant