Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android:fullBackupContent from AndroidManifest.xml #100

Open
mikaelbartlett opened this issue Oct 9, 2019 · 5 comments
Open

Remove android:fullBackupContent from AndroidManifest.xml #100

mikaelbartlett opened this issue Oct 9, 2019 · 5 comments
Assignees
Labels

Comments

@mikaelbartlett
Copy link

I get a merge error with other libraries that also contains this.

Please remove this as the app should decide how to handle backup.

@roeeba
Copy link

roeeba commented Oct 10, 2019

Hi @mikaelbartlett, can you please let us know with which library it conflicts?

@roeeba roeeba self-assigned this Oct 10, 2019
@mikaelbartlett
Copy link
Author

Hi @roeeba

pusher/push-notifications-android#89 here's the link to the other library.

@roeeba
Copy link

roeeba commented Oct 17, 2019

Thanks, @mikaelbartlett. I'm assigning it to our mobile engineer to further investigate.

@roeeba roeeba assigned nitzanj and unassigned roeeba Oct 17, 2019
@waliahimanshu
Copy link

We run into similar issues where we get a lint error due AndroidManifest not respecting android 12 changes.

/root/.gradle/caches/transforms-3/6a5afdf55df46ace7be55e9720e00da9/transformed/cloudinary-android-core-2.3.0/AndroidManifest.xml:11: Error: Missing <full-backup-content> resource [DataExtractionRules]
    <application android:fullBackupContent="@xml/backup_config" />
                                            ~~~~~~~~~~~~~~~~~~
   Explanation for issues of type "DataExtractionRules":
   Before Android 12, the attributes android:allowBackup and
   android:fullBackupContent were used to configure all forms of backup,
   including cloud backups, device-to-device transfers and adb backup.
   In Android 12 and higher, these attributes have been deprecated and will
   only apply to cloud backups. You should instead use the attribute
   android:dataExtractionRules, specifying an @xml resource that configures
   which files to back up, for cloud backups and for device-to-device
   transfers, separately. If your minSdkVersion supports older versions,
   you'll still want to specify an android:fullBackupContent resource if the
   default behavior is not right for your app.
   https://developer.android.com/about/versions/12/backup-restore#xml-changes
1 errors, 0 warnings
FAILURE: Build failed with an exception.

@adimiz1 adimiz1 mentioned this issue Nov 10, 2022
10 tasks
@michalkcloudinay
Copy link

Hi @waliahimanshu,

I just want to update you that this was fixed in the Android SDK 2.3.1 version.
I will go ahead and close this for now. Do let us know if you have any issues.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants