Remove remote_port label from flow_traffic metrics #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cloudflare#94. However it theoretically has the potential to break some existing usecases, where the distiction between remote ports is relevant. Signed-off-by: Tobias Guggenmos <tobias.guggenmos@uni-ulm.de>
|
I was a bit alarmed by this, but the IOS-XR flow export we use does not randomize the source port regularly, may be even only on chassis reload. Still, this seems like a good precaution, I don't really see what you'd use that label for. |
SuperQ
approved these changes
Mar 27, 2021
|
Ping @lspgn. 😄 Any chance we can get some reviews and a release? |
|
Hello, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
However it theoretically has the potential to break some existing usecases, where the
distiction between remote ports is relevant.
Signed-off-by: Tobias Guggenmos tobias.guggenmos@uni-ulm.de