Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lock followers on full_sync #675

Closed
kickster97 opened this issue May 13, 2024 · 0 comments
Closed

Don't lock followers on full_sync #675

kickster97 opened this issue May 13, 2024 · 0 comments
Assignees

Comments

@kickster97
Copy link
Member

We call follower.full_sync in the lock synchronize block which causes the entire broker to pause while sync is happening.

Is this necessary or can we call full_sync outside of synchronize, before read_acks, and let the actions queue handle the back pressure? I.e. the broker will be paused if the syncing follower’s action queue is full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants