Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg file size does not match #671

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

viktorerlingsson
Copy link
Member

@viktorerlingsson viktorerlingsson commented May 7, 2024

WHAT is this pull request doing?

Handles a case where a msg file size is bigger than expected, but only by less then BytesMessage::MIN_BYTESIZE. Then it can not contain another message, and should probably be ignored.

fixes: #669

HOW can this pull request be tested?

Run spec

Copy link
Member

@carlhoerberg carlhoerberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more generic than just BytesMessage::MIN_BYTESIZE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the queues are closed
2 participants