Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug #35

Open
bozhinov opened this issue Jan 26, 2021 · 1 comment
Open

Possible bug #35

bozhinov opened this issue Jan 26, 2021 · 1 comment
Assignees

Comments

@bozhinov
Copy link
Contributor

$res=$this->cbsd_cmd("freejname".$add_cmd.$add_cmd1);

$add_cmd=($in_helper)?' default_jailname='.$this->url_hash:'';
$add_cmd1=' default_jailname='.$type;
$res=$this->cbsd_cmd("freejname".$add_cmd.$add_cmd1);

after refactoring this translates to:
if ($in_helper) {
$res = CBSD::run('freejname default_jailname=%s default_jailname=%s', array($this->url_hash, $type));
} else {
$res = CBSD::run('freejname default_jailname=%s', array($type));
}

The double default_jailname looks weird
it this correct ?

@olevole olevole self-assigned this Jan 31, 2021
@olevole
Copy link
Member

olevole commented Feb 21, 2021

@moveee cbsd assumes one argument for default_jname. Can you check and remove the dubbing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants