Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The caller of a reducer call should always receive the result even if they’re not subscribed to any of the tables that have changed #1127

Closed
joshua-spacetime opened this issue Apr 19, 2024 · 4 comments · Fixed by #1111
Closed

The caller of a reducer call should always receive the result even if they’re not subscribed to any of the tables that have changed #1127

joshua-spacetime opened this issue Apr 19, 2024 · 4 comments · Fixed by #1111
Assignees
@drogus

Comments

@joshua-spacetime
Copy link
Collaborator

John Dec 11th: We've talked about this issue many times, I'll test to see if we actually implemented this or not.

Piotr: as far as I've checked it doesn't work yet, so I'll look into it
@joshua-spacetime joshua-spacetime linked a pull request Apr 19, 2024 that will close this issue
Always send TransactionUpdate to the sender #1111
Merged
3 tasks
@drogus
Copy link
Collaborator

drogus commented May 13, 2024

PR: https://github.com/clockworklabs/SpacetimeDB/pull/1111/files

@cloutiertyler
Copy link
Contributor

The caller should receive an event with no rows if they are not subscribed to any of the rows that have changed.

@cloutiertyler
Copy link
Contributor

@gefjon to add an SDK test before merging

@gefjon
Copy link
Contributor

gefjon commented May 15, 2024

@gefjon to add an SDK test before merging

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drogus drogus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always send TransactionUpdate to the sender clockworklabs/SpacetimeDB
4 participants
@drogus @cloutiertyler @gefjon @joshua-spacetime