Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressing exceptions caught in the pipeline might lead to undefined behavior #453

Open
kachayev opened this issue Dec 18, 2018 · 0 comments

Comments

@kachayev
Copy link
Collaborator

Both server and client handlers simply log all caught exceptions. In case something goes wrong in the pipeline, processing might be stuck. E.g. when a server responds unexpectedly, Netty throws io.netty.handler.codec.EncoderException making the connection effectively useless. I'm not sure what is the best approach handling exceptions for the server, but at least for the client we probably need to clean up (close connection?) or propagate exception as the request result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant