Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React v. 18 #844

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support React v. 18 #844

wants to merge 2 commits into from

Conversation

patrykboch
Copy link

Fixes #838

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2022 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f28d4ac:

Sandbox Source
react-sortable-hoc-starter Configuration

@patrykboch
Copy link
Author

@clauderic please review

@patrykboch
Types: change React.SFC and React.ComponentClass with `React.Comp…
f28d4ac 
…onentType`

* `React.SFC` type is no longer supported with React v. 18 (becomes `React.FC`)
* Since `React.ComponentClass` was specified the proper type now is `React.ComponentType` that covers both `React.FC` and `React.ComponentClass`
@patrykboch patrykboch changed the title Add react 18.1.0 to peer deps Support React v. 18 Jun 10, 2022
@chrishawn
Copy link

yes please review

@patrykboch
Copy link
Author

patrykboch commented Jun 15, 2022 •
edited

@chrishawn I'm afraid it might never be introduced. The lib is considered deprecated and further enhancements won't be merged. Only security fixes. See @dnd/kit as an alternative.

Anyways migration to @dnd/kit is not obvious and it'd be perfect to have the support of React v18 here. The newest version of React does ensure backward compatibility.

I see that ReactDOM.findDOMnode, ReactDOM.render, etc. are in fact deprecated but it does not mean they neither work with the latest React nor the lib in question. So please, @clauderic consider this.

@alexander-schranz alexander-schranz mentioned this pull request Jul 10, 2022
Closed
@alexander-schranz
Copy link

Would also like to see this merged. We can also not migrate away currently to another package. So would really like to see 18 official supported here.

@arneee
Copy link

arneee commented Jul 19, 2022

@clauderic : Please support that. We are using this package on so many pages so it will be a huge effort to migrate. Since the methods are still there (only deprecated), I really hope that this will be merged. Thanks!!!

@SergioArrighi
Copy link

Hello,
thanks for your work.
Any target date for this to be merged?
Best regards

@marwin1991
Copy link

@clauderic Is there any migration guide to dnd-kit?

@williamstein williamstein mentioned this pull request Nov 1, 2022
Closed
2 tasks
@marco-adapttech
Copy link

Hello,

Any updates for when it will be released?

Thanks everyone for the work.

@Artexoid
Copy link

Artexoid commented Mar 1, 2023 •
edited

Hi guys, merge it please.

@3y3 3y3 mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetozantekin ahmetozantekin ahmetozantekin approved these changes

@rcuellartso rcuellartso rcuellartso approved these changes

@mdemian-verys mdemian-verys mdemian-verys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not supporting in react@18.0.0