Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized versions for feature parity #328

Open
classilla opened this issue Sep 11, 2016 · 93 comments
Open

Localized versions for feature parity #328

classilla opened this issue Sep 11, 2016 · 93 comments
Assignees

Comments

@classilla
Copy link
Owner

This will involve custom strings.

See #42 for history.

@chris-chtrusch
Copy link
Collaborator

Updated Locale installers with copyright 2018, fix for print/open/save dialogs and allowing for 'FPRx.y' version strings up to FPR10.5 in the version check routine. I did not use placeholders so we can easily exclude earlier versions of the browser when new custom strings or other changes are introduced that would make the installers incompatible with these versions. Also renamed the installers to show 'FPR' since '45' probably confuses people by now.

TFF-FPR.x-Langpack-Finnish.app.zip
TFF-FPR.x-Packlangage-Français.app.zip
TFF-FPR.x-Sprachpaket-Deutsch.app.zip
TFF-FPR.x-Langpack-Italiano.app.zip
TFF-FPR.x-Polski_pakiet_jezykowy.app.zip
TFF-FPR.x-Langpack-Russian.app.zip
TFF-FPR.x-Langpack-Spanish.app.zip
TFF-FPR.x-Langpack-Swedish.app.zip

@chris-chtrusch chris-chtrusch self-assigned this Jan 8, 2018
@classilla
Copy link
Owner Author

classilla commented Jan 9, 2018 via email

@classilla
Copy link
Owner Author

Replaced on home page.

@nemanjacosovic
Copy link

How could one join in on translating TFF?

@classilla
Copy link
Owner Author

Look at https://github.com/classilla/tenfourfox/wiki/Localization . If you feel able to do so, post the pack as an attachment here and we can get it processed for general availability.

@chris-chtrusch
Copy link
Collaborator

There are slight changes in the About Dialog credits/contributers list starting with FPR6. Modified the German installer accordingly. I think it should be sufficient to slip this in for all installers on occasion when something else needs to be fixed or updated.
TFF-FPR.x-Sprachpaket-Deutsch.app.zip

@classilla
Copy link
Owner Author

classilla commented Mar 11, 2018 via email

@chris-chtrusch
Copy link
Collaborator

The key is <!ENTITY contribute.start … and yes, there's some English in it.

@chris-chtrusch
Copy link
Collaborator

Localizations need updates for samesite cookie support in the developer tools.
Line 'table.headers.cookies.sameSite=sameSite' is missing in 45 based localizations in storage.properties. Since the string 'same site' doesn't seem to be translated in FF60 localizations anyway (checked DE, FR, IT), I'll just copy that line over from TFF FPR8b1.

At the same time I'll update the version checker for versions >FPR10 because we're getting near that number, and remove support for <FPR8. We should keep an archive of the installers valid for up to FPR 7.

Also I'll update contributers in the about dialog.

Will post installers here shortly.

@classilla
Copy link
Owner Author

classilla commented Jun 18, 2018 via email

@classilla
Copy link
Owner Author

Uploaded and live.

@httpsgithu
Copy link

will it be a chinese version?

@chris-chtrusch
Copy link
Collaborator

It can be done. Do you mean Simplified or Traditional Chinese?

The problem is that, unlike Latin, Cyrillic and a little Greek, I'm illiterate in Chinese. I need a volunteer (native speaker if possible) to do quality control and translate a few text strings for functionality that is only in TenFourFox, not in Firefox. Can you do this?

@chris-chtrusch
Copy link
Collaborator

I need to update the © date in the about dialog, also update the version checker for TFF 14ff. While I'm at it: Any new strings to add?

@paizhangpi
Copy link

It can be done. Do you mean Simplified or Traditional Chinese?

The problem is that, unlike Latin, Cyrillic and a little Greek, I'm illiterate in Chinese. I need a volunteer (native speaker if possible) to do quality control and translate a few text strings for functionality that is only in TenFourFox, not in Firefox. Can you do this?

I'm native speaker, 2 years user of TFF and glad to help the translation of TFF in Simplified Chinese. https://github.com/classilla/tenfourfox/wiki/Localization I read that but it's quite hard for me to understand. Could you please guide me to join the translation if there's a easier way

@chris-chtrusch
Copy link
Collaborator

chris-chtrusch commented Apr 1, 2019

Paizhangpi, I'm just going to need the strings in the attached text file translated to Simplified Chinese, then I can start making the installer app. Thank you!
strings to translate.txt

@paizhangpi
Copy link

@paizhangpi
Copy link

paizhangpi commented Apr 1, 2019

(The Applescript dialogs will have to stay English because Applescript for 10.4 doesn't support non-ascii characters.)
(AppleScript对话框将使用英文,因为Mac OS X 10.4的AppleScript不支持非ASCII字符。)

@chris-chtrusch
Copy link
Collaborator

Thank you! I will make the installer during the next weekend. I'll try to use the complete sentence in the About Tenfourfox dialog, I suspected such a problem :-)

I forgot this string for the About Tenfourfox dialog:
Mozilla Community Credits

@paizhangpi
Copy link

That's no problem at all. TenFourFox let my powerful PowerPC Mac reborn, so I'm happy to join the translation of my native language. Feel free to contact me for further problem.
the message is from TenFourFox running on my QUAD G5.

Mozilla Community Credits
Mozilla 社区贡献者列表

@classilla
Copy link
Owner Author

I need to update the © date in the about dialog, also update the version checker for TFF 14ff. While I'm at it: Any new strings to add?

If the MP4 stuff sticks, we might expose that pref. I haven't decided yet, but an "Enable H.264 video" couldn't hurt, I suppose. It's not critical however.

@chris-chtrusch
Copy link
Collaborator

Alright, I'll add these; since the grammar should be consistent and we have enough other things that can be 'enabled' I could even translate this myself. I'm planning to upload all new installers incl. Chinese on the weekend.

@chris-chtrusch
Copy link
Collaborator

chris-chtrusch commented Apr 6, 2019

Cameron, can we go with

ENTITY TFFh264.title "H.264 video"
ENTITY TFFh264.prompt "Enable H.264 video"

in TenFourFox.dtd, and

TFFh264.title.p = H.264 video
TFFh264.prompt.p = Enable H.264 video

in TenFourFox.properties?

@classilla
Copy link
Owner Author

I was thinking about that. I think it might be better for the prompt to be

"Enable H.264 video (requires MP4 Enabler)"

but I don't know how feasible that would be with the extra localization phrase. Your call.

@chris-chtrusch
Copy link
Collaborator

I'll leave the parentheses in English if I'm unsure and change it in a later edition, it's not being exposed right now anyway.

@chris-chtrusch
Copy link
Collaborator

Langpack installers updated for FPR 14+. Changes:
• © date in about dialog
• contributers in about dialog
• h.264 strings
• updated version check routine in applescript

TFF-FPR14-Langpack-Spanish.app.zip
TFF-FPR14-Polski_pakiet_jezykowy.app.zip
TFF-FPR14-Langpack-Finnish.app.zip
TFF-FPR14-Packlangage-Français.app.zip
TFF-FPR14-Sprachpaket-Deutsch.app.zip
TFF-FPR14-Langpack-Russian.app.zip
TFF-FPR14-Langpack-Swedish.app.zip
TFF-FPR14-Langpack-Italiano.app.zip

@chris-chtrusch
Copy link
Collaborator

German test installer for FPR 28 and up. Added "Enable JavaScript" translation.
Cameron, any other new strings to add here?
TFF-FPR28-Sprachpaket-Deutsch.zip

@classilla
Copy link
Owner Author

I don't know if I'm going to use these, but let's add these or something like it as well while we're doing it:

"Domain" (this may be already there)
"Configure Site Preferences"
"Always Open in Reader View"

This is for an idea I have about per-domain configuration. Not sure how feasible it is yet. Let me know if these strings will be troublesome.

@chris-chtrusch
Copy link
Collaborator

chris-chtrusch commented Oct 5, 2020

Should these go in browser.dtd?
I need the complete labels like
<!ENTITY JavascriptToggleCmd.label "Enable JavaScript">
to be able to put them in the langpacks.

@chris-chtrusch
Copy link
Collaborator

chris-chtrusch commented Nov 5, 2020

German test installer for TFF FPR 29. Please test.

Two things:

  1. (only for German) Id'l like to use a more literal German translation for "Ludicrous [speed]" than the dull "Doppelte Geschwindigkeit" the official Firefox has – a reference to Spaceballs. Any objections to "Wahnsinnig", which is in the German dub of the movie? Mel Brooks is well known and loved in German-speaking countries, many people will get the joke.

  2. I was a bit puzzled when I made the installer. In browser.dtd there is a new menu item in the View menu toggleReaderMode.label "Toggle Reader Mode". Is this used for anything? Is it supposed to be hidden and then replaced by "Enter reader view" when Reader Mode is available (which grabs a pre-existing locale string from somewhere else)? When I startup the browser with an empty page, I do see "Toggle Reader Mode" (Picture 1), but when I open a new tab it's gone (Picture 2), then when Reader Mode is available, the new item appears (Picture 3).

TFF-FPR29-Sprachpaket-Deutsch.app.zip

Picture 1
Picture 2
Picture 3

@classilla
Copy link
Owner Author

classilla commented Nov 5, 2020

I'm not on the G5 at the moment, but I think it's the tooltip for the "book" icon. I'm fine with a more culturally appropriate translation. :)

@classilla
Copy link
Owner Author

(It probably shouldn't be enabled on about:blank pages either. That's a separate bug.)

@chris-chtrusch
Copy link
Collaborator

The Toolbar tip for the Book icon is 'Toggle Reader View', that's what we localize in browser.properties. 'Toggle Reader Mode' in browser.dtd seems to be the string for the View Menu item which shouldn't be visible anytime, I agree. What I don't understand is: Why do we need it in the first place? Is it necessary so that the ⌥R command works, or is it a placeholder for 'Enter/Close Reader View'?

@classilla
Copy link
Owner Author

I'm fine with treating it as a placeholder, but I think it's still needed for the XUL.

@chris-chtrusch
Copy link
Collaborator

I think my German test installer for 29 is technically o.k., then. I'll make the other ones accordingly.

@classilla
Copy link
Owner Author

Uploaded to SourceForge. Thanks, Chris!

@chris-chtrusch
Copy link
Collaborator

chris-chtrusch commented Mar 13, 2021

We need new translations for site specific user agents and reader view. Please edit the file strings-for-31fpr.txt (attached) and re-attach it to your post. If you keep the structure of the lines and item tags you make my life easier when I assemble the langpack installers. Thank you!

Some hints, because much of the work has already been done:

Have a look at the wording that's already in the TenFourFox preferences pane and elsewhere (strings such as 'user agent'; 'reader view', 'custom' etc.) and keep your translations consistent.

Strings such as 'site specific', 'predefined', 'sub pages' or 'mode' have already been translated in other contexts for modern versions of Firefox (e.g. 'create site specific notes'; 'enable night mode' etc.); please check pontoon.mozilla.org and decide whether the translations found there make sense in our context. It's your decision as a native speaker, but I'd like to keep translations as consistent to Firefox as possible.

Keep in mind that the user agent feature is actually domain specific, i.e. you cannot define a single page with a /. Try to be specific in your wording (domain/website vs. web page).

  • Chinese (simplified)
  • Finnish
  • French
  • German
  • Italian
  • Korean
  • Polish
  • Russian
  • Spanish
  • Swedish
  • Turkish

strings-for-31fpr.txt

German test installer for TFF 31 FPR:

TFF-FPR31-Sprachpaket-Deutsch.app.zip

@nodarkthings
Copy link

French
strings-for-31fpr.FR.txt

@nodarkthings
Copy link

Italian (it was not that difficult ;-) )
strings-for-31fpr.IT.txt

@classilla
Copy link
Owner Author

Are we OK launching with the Site Specific dialogue, or do we want to wait a cycle? I can disable it for release and reenable for the next beta. I need to start the build in the next 24 hours to have sufficient time for testing.

@chris-chtrusch
Copy link
Collaborator

Technically, we're OK. We won't have all translations ready in time, but that would also be true if we waited one more cycle (we haven't had contributions for some languages in ages). The new UI parts can stay English for the time being, I can add whatever arrives later at the next occasion. French+Italian+German cover ~75% of the user base for localizations.

@classilla
Copy link
Owner Author

classilla commented Mar 18, 2021

OK, thanks. If you change your mind I'll still be working on it a few more hours to finish and certify the security review, and then I'll start the build overnight.

@chris-chtrusch
Copy link
Collaborator

Updated installers for FPR 31.

Changes: Set © date to 2021; added strings for auto reader view and site specific user agent, updated version check routine.

Thank you @nodarkthings for contributing French & Italian translations. Languages other than German, French and Italian have the new UI parts in English to make the XUL work. Translations for these can still be added at a later stage. If you're able to help, please contribute. It's only a few lines. The UI parts affected are mostly variable in width and hight, so you don't even have to get too creative this time to constrain your text length (which is always a challenge, at least for German).

TFF-FPR31-Langpack-Chinese-simplified.zip
TFF-FPR31-Langpack-Finnish.zip
TFF-FPR31-Langpack-Italiano.zip
TFF-FPR31-Langpack-Korean.zip
TFF-FPR31-Langpack-Russian.zip
TFF-FPR31-Langpack-Spanish.zip
TFF-FPR31-Langpack-Swedish.zip
TFF-FPR31-Langpack-Turkish.zip
TFF-FPR31-Packlangage-Français.zip
TFF-FPR31-Polski_pakiet_jezykowy.zip
TFF-FPR31-Sprachpaket-Deutsch.zip

@nodarkthings
Copy link

nodarkthings commented Mar 20, 2021

If no one ever applies for the Spanish translation, just ask me before next release or when you feel appropriate. I haven't done it this time because I thought it would be one of the easiest languages for which to find a native speaker... And also because I'm not sure my translation would be reliable enough — but I think it probably would be 90% ok, anyway. ;-)

@classilla
Copy link
Owner Author

If worst comes to worst, I can do the Spanish translation. I'm not a native speaker either but I speak it regularly.

@chris-chtrusch
Copy link
Collaborator

It's not my final decision, but having worked as a professional translator for almost a decade I find it hard to abandon Rule Number One that the target language must be your native language, or at least the text must be proof-read by a native speaker before publication.

@classilla
Copy link
Owner Author

I don't disagree. Just another option.

@chris-chtrusch
Copy link
Collaborator

Seeing auto reader view in action in FPR 32 required a semantic correction in the German translation.

TFF-FPR31-Sprachpaket-Deutsch.zip

@classilla
Copy link
Owner Author

Uploading as a running change.

@chris-chtrusch
Copy link
Collaborator

The langpack installers will stop working after FPR 32.3 (45.41.3) since I didn't expect there to be more than four minor versions per FPR version. Should I update the installers with a new version check routine for 32.x one last time? Or (better perhaps) put a readme in the SourceForge directory telling people how they can extend the check routine by themselves (it's a simple list in the AppleScript)?

@classilla
Copy link
Owner Author

Is both possible? Then future builders will know what to do, but at least the legacy users are taken care of until the end.

@chris-chtrusch
Copy link
Collaborator

OK, I'll upload the installers to langpacks/FPR32 plus a readme.markdown with instructions for builders how to adjust the version check routine. What's the number that ends up being displayed as "Version" in the Finder column view? config/milestone.txt or browser/config/version.txt? They both currently have '45.41.3'.

@classilla
Copy link
Owner Author

They should always match but that particular string always comes from browser/config/version.txt.

configure.in:FIREFOX_VERSION=`cat $_topsrcdir/browser/config/version.txt`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants