Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated depedencies: ckeditor5-markdown-gfm -> [abab@2.0.6, domexception@2.0.1, w3c-hr-time@1.0.2] #16371

Closed
jamesst20 opened this issue May 16, 2024 · 1 comment · Fixed by #16372
Closed

Deprecated depedencies: ckeditor5-markdown-gfm -> [abab@2.0.6, domexception@2.0.1, w3c-hr-time@1.0.2] #16371

jamesst20 opened this issue May 16, 2024 · 1 comment · Fixed by #16372
Assignees
@filipsobol
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 75

Comments

@jamesst20
Copy link

jamesst20 commented May 16, 2024 •
edited

Dependency tree:

'@ckeditor/ckeditor5-markdown-gfm@41.4.1':
    turndown@6.0.0: <-- Upgrade to 7.1.3
        dependencies:
          jsdom: 16.7.0 <-------- Very old
            abab@2.0.6, domexception@2.0.1, w3c-hr-time@1.0.2. <-- All 3 are deprecated

Could you please update it :)

Thanks!
@jamesst20 jamesst20 added the type:bug This issue reports a buggy (incorrect) behavior. label May 16, 2024
@filipsobol filipsobol self-assigned this May 19, 2024
@Reinmar Reinmar mentioned this issue May 20, 2024
Closed
@Reinmar
Copy link
Member

Reinmar commented May 20, 2024

AFAIK @filipsobol is currently working on this in #16372.

@filipsobol filipsobol mentioned this issue May 20, 2024
Merged
filipsobol added a commit that referenced this issue Jun 3, 2024
@filipsobol
Merge pull request #16372 from ckeditor/turn-markdown-and-html-proces…
990afc7 
…sorors-to-classes

Other (markdown-gfm): Refactor `html2markdown` and `markdown2html` to classes to improve tree-shaking. Related to #16292.

Other (markdown-gfm): Upgrade `turndown` to version `7.2.0`. Closes #16371.
@CKEditorBot CKEditorBot added this to the iteration 75 milestone Jun 3, 2024
@CKEditorBot CKEditorBot mentioned this issue Jun 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsobol filipsobol

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 75
Development

Successfully merging a pull request may close this issue.

Refactor html2markdown and markdown2html to classes and upgrade turndown ckeditor/ckeditor5
4 participants
@Reinmar @jamesst20 @filipsobol @CKEditorBot