Replace Pylons routes for build_nav_icon #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires conditionals, as the extension still needs to work on older ckan versions. Thats why tests are failing. |
|
Any suggestion/example on how to handle these conditionals properly? |
|
@frafra maybe you can use the in the templates to use the newer routes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #476
I am not sure why
adminandaboutrequireharvester.as prefix instead of the variabledataset_type, but it seems to work for me.This PR does not replace all the Pylons routes: there are still a lot of deprecation warnings. This is just the bare minimum to make
ckanext-harvestwork with the current CKAN. I also prefer to send small fixes as they can be more easily reviewed instead of trying to replace all the routes at once.