Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for built-string format checks #18

Open
jcockhren opened this issue Dec 6, 2022 · 1 comment · May be fixed by #32
Open

Add support for built-string format checks #18

jcockhren opened this issue Dec 6, 2022 · 1 comment · May be fixed by #32

Comments

@jcockhren
Copy link
Member

https://json-schema.org/understanding-json-schema/reference/string.html#built-in-formats

@jcockhren jcockhren linked a pull request May 19, 2023 that will close this issue
13 tasks
@jcockhren
Copy link
Member Author

jcockhren commented May 26, 2023

On second thought, string format checks may be a bridge too far (at least not as a core feature):

  • Natively implementing multiple RFCs is a large undertaking and could be a project in and of itself.
  • Format-specific error messages would require a complete re-work of error handling.
  • A quick implementation would require new 3rd party dependencies. e.g., uritools or rfc3987

Given the availability of pre-existing libraries useful for constructing, parsing, and validating URI strings, this feature would be best served as an "extra" with (well-supported) optional dependencies. See commit 4eb1db5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant