Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose core classes for custom usage #2

Open
robhawkes opened this issue May 25, 2021 · 1 comment
Open

Expose core classes for custom usage #2

robhawkes opened this issue May 25, 2021 · 1 comment

Comments

@robhawkes
Copy link

robhawkes commented May 25, 2021

Description

  • The way I am using the CityJSON parser differs to the general implementation available within the core exports
  • For example, CityJSONWorkerParser does a lot though I want more control and customisation over geometry generation
  • Another example is to implement a parser into my own worker scripts (CityJSONWorkerParser tries to create its own worker)
  • Or I may want to create an entirely different data management mechanism like streams, or worker pools
  • Manually accessing ChunkParser has been helpful for me but it's not accessible via the root / index file

Expectation

  • Expose all the useful classes from the parser in the root / index file (at least ChunkParser and GeometryParser)
  • Core classes can be used to perform basic parsing so I can perform my own geometry processing or mesh / material application
@liberostelios
Copy link
Contributor

Thanks for the remark! The plan is to have all classes available to the user so that they can use composition to enable whatever behaviour the want (or to extend the functionality). I was just lazy to do it so far, as I am still experimenting with things. 😇

Except for just exposing these files through the index, do you think there is a way that ChunkParser and GeometryParser can become more extensible? I am worried that these classes might be already a bit overloaded and could be decomposed even further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants