Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi LoD file adds empty attributes to all layers #40

Open
balazsdukai opened this issue Sep 29, 2021 · 3 comments
Open

Multi LoD file adds empty attributes to all layers #40

balazsdukai opened this issue Sep 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@balazsdukai
Copy link
Member

I'm loading a multi-lod file with BuildingBarts which has attributes only on the Building.
I load the file by splitting the lod-s to layers.
Then each lod-layer obtains the attributes from the Building, all with NULL, although they don't have attributes on their own.

File: https://data.3dbag.nl/cityjson/v210908_fd2cee53/3dbag_v210908_fd2cee53_5786.json

@liberostelios liberostelios added the enhancement New feature or request label Sep 29, 2021
@liberostelios
Copy link
Contributor

This is true. It's expected that all layers have all attributes that are identified in the whole dataset. The same applies to per object type layers.

I assume that it's not that problematic, but I can imagine that it can be annoying. I'll, therefore, flag it as an enhancement.

I guess there could be an option to remove unused fields in layers.

Any thoughts on that?

@Athelena
Copy link
Contributor

Perhaps it would be useful to have an option to inherit attributes from the parent? Specifically in cases where you only want to work with one LoD.

@liberostelios
Copy link
Contributor

liberostelios commented Sep 29, 2021

That's a great point! I think it would be really useful for 3D BAG specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants