Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

positional encoding #27

Open
Torment123 opened this issue Mar 9, 2024 · 1 comment
Open

positional encoding #27

Torment123 opened this issue Mar 9, 2024 · 1 comment

Comments

@Torment123
Copy link

Hi, thanks for the great work and congrats for CVPR acceptance. I saw in the code that ob_dist and ob_view are directly concatenated with anchor feature and input to the MLPs. Would using positional encoding (like in NeRF) further improve the view-dependent appearance rendering? as it captures high frequency variations, thanks.

@inspirelt
Copy link
Collaborator

Thanks. We choose direct concatenation because 1) reducing the total computation; 2) we find that a naive PE does not always contribute to a better results. Further explorations are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants