Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure domain Request and domain Info have "Non-federal" instead of None when empty #2147

Closed
2 tasks
abroddrick opened this issue May 7, 2024 · 0 comments · Fixed by #2169
Closed
2 tasks

Ensure domain Request and domain Info have "Non-federal" instead of None when empty #2147

abroddrick opened this issue May 7, 2024 · 0 comments · Fixed by #2169
Assignees
@zandercymatics
Labels
dev

Comments

@abroddrick
Copy link
Contributor

abroddrick commented May 7, 2024 •
edited by PaulKuykendall

Issue description

For ease of filtering and for consistency, we should make sure when a non federal domain is approved it's agency is not None and is instead Non-federal agency.

Acceptance criteria

  • in the Domain request approval function, if federal agency is None change it to "Non-federal" agency
  • be sure this happens before Domain Information is made so that Domain information is now non-federal agency as well

Additional context

No response

Links to other issues

No response
@abroddrick abroddrick added the dev label May 7, 2024
@zandercymatics zandercymatics self-assigned this May 14, 2024
@zandercymatics zandercymatics mentioned this issue May 14, 2024
Merged
46 tasks
zandercymatics added a commit that referenced this issue May 16, 2024
@zandercymatics
Merge pull request #2169 from cisagov/za/2147-show-non-federal-for-fe…
cfce03a 
…deral-agency

Ticket #2147: Ensure domain Request and domain Info have "Non-federal" instead of None when empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zandercymatics zandercymatics

Labels
dev
Projects
.gov Product Board
Status: ✅ Done
Milestone
No milestone
2 participants
@abroddrick @zandercymatics