New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Federal Agency drop down with the federal agency table #1793
Comments
Changing epic to org model because it's preliminary to that work. |
I've refined the text and struck a few things from this task. The refinement label stays to talk about "hiding" two values. Before we add an "other" field that prompts for a user-supplied value, let's determine how this selection would flow into the rest of the request form/DjAdmin/notification emails that are sent. @kristinacyin |
updated language on AC 3 |
In refinement, we decided to take this opportunity to create a table for federal agencies and to make the domain mapping A/C its own issue. @abroddrick will take a first pass. |
Moved status backed to "Planned" to "Ready" since it was moved out from sprint 43 into sprint 44. |
This is Ticket #3 for Federal Agency |
Removed "blocked" label since the tickets that are blocking this ticket are closed. |
ISSUE #1793: Connect new federal agency table to domain requests and admin
Current Behavior
We recently added the federal agencies table, but it is not connected to anything, we should connect it to in the "Organization name and mailing address" (for org type "Federal") request page and anywhere else the federal agency field is used.
Note in the current state in the "Organization name and mailing address" (for org type "Federal") request page, the current "Federal agency" dropdown shows duplicate entries which do not exist in the federal agency table (they were removed intentionally). There is also an invalid option in the dropdown: "State, Local, and Tribal Government" which should be just Non-Federal Agency instead. These duplicate and incorrect values do not exist in the Federal Agency table; however, there is a migration script ticket (#1975) to update any 'deprecated' values to the correct ones to use. If you pick up this current ticket, the migration ticket is a logical choice to work at the same time. They should be merged around the same time.
There are also 2 values we should keep but not allow end users to select:
Acceptance Criteria
In the request form's Federal Agency dropdown, include an "other" field to allow users to add an agency not in our list (ignore this one)remove the old federal_agency field as it is no longer needed and be sure the now linked Agency field now shows on the django admin exactly where federal_agency was showing and that the field is viewable for all users (note the goal is to make it look like nothing changed for analysts)federal_agency
2: Migration file to RENAMEupdated_federal_agency
tofederal_agency
(updated_federal_agency now filled in at this point, so we have to delete + rename)Additional Context
Slack thread discussion
Issue Links
blocked by #1896
blocked by #2029
Relates to #1975 (do at around the same time to avoid issues)
Relates to: #337
The text was updated successfully, but these errors were encountered: