Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why strip the writer credit distinguisher? #492

Open
fshowalter opened this issue Nov 26, 2023 · 1 comment
Open

Why strip the writer credit distinguisher? #492

fshowalter opened this issue Nov 26, 2023 · 1 comment

Comments

@fshowalter
Copy link

Hey all,

Unless I'm reading the code wrong, it looks like:

if role_comment[-4:] == ' and':

Strips the "&" and "and" from the end of the notes from the writer credits. Via https://www.wga.org/uploadedfiles/credits/manuals/screenscredits_manual10.pdf these are important differentiators as:

When credit is accorded to a team of writers, an ampersand (&) shall be used between the writers’ names in the credit to denote a writing team. Use of the word “and” between writers’ names in a credit indicates that the writers did their work separately, one usually rewriting the other.

Happy to submit a fix, but wanted to know how you'd prefer it (i.e. separate parser, tweaked rule, tweak to person_builder, etc..)

@uyar
Copy link
Collaborator

uyar commented Nov 27, 2023

It might or might not be a problem. It looks like it's stripping the trailing "and" which is not followed by anything. It might be that the parser rule causes the "and" between the writers to end up in the role field of the previous writer where it doesn't belong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants