Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person biography not working (please urgent i need it for my bachelor thesis) #462

Open
elenado01 opened this issue May 27, 2023 · 3 comments
Assignees
Labels
bug http parsers of IMDb web pages

Comments

@elenado01
Copy link

Issue description

I'm trying to obtain the biography of a person, but all of them raise an error. It is strange, since i ran the same code a few months ago and the biographies from the actors were available. Does anyone know if it is a general issue with the package or is it just me?

Version of Cinemagoer, Python and OS

NOTICE: please always try the latest version from the repository before submitting a bug.

  • Python: python3 -V or, if you are using Python 2, python -V
  • Cinemagoer: python3 -c 'import imdb ; print(imdb.VERSION)' or, if you are using Python 2, python -c 'import imdb ; print(imdb.VERSION)'
  • OS: python -c 'import platform ; print(platform.uname())'

Steps to reproduce the issue

if possible, provide a minimal code to reproduce the problem

#!/usr/bin/env python
from imdb import Cinemagoer
# create an instance of the Cinemagoer class
ia = Cinemagoer()

person = ia.get_person('0000401')
person['biography']

What's the expected result?

  • before the infoset2keys showed this:
    {'main': ['headshot', 'filmography', 'imdbID', 'name'],
    'biography': ['headshot',
    'nick names',
    'birth name',
    'height',
    'mini biography',
    'trade mark',
    'trivia',
    'quotes',
    'salary history',
    'birth date',
    'birth notes']}

What's the actual result?

  • {'main': ['headshot', 'filmography', 'imdbID', 'name'], 'biography': []}

Additional details

@elenado01 elenado01 changed the title Person biography not working Person biography not working (please urgent i need it for my bachelor thesis) May 27, 2023
@DirkWuerdemann
Copy link

Hi all, I have the same Issue. When I read the the actress nm0726257 Katja Riemann I got in the last Version (2022.12.04) a Key "mini biography" and also values for "trivia". This is not available any more in version 2023.05.01. Same for "birth date", "birth name" and "birth notes"

@alberanid alberanid self-assigned this Jul 1, 2023
@alberanid alberanid added bug http parsers of IMDb web pages labels Jul 1, 2023
alberanid added a commit that referenced this issue Jul 1, 2023
@alberanid
Copy link
Collaborator

Yep, I can confirm that they changed again and again and again the format of the web pages.

I'm in a hurry, so I've just committed a quick fix for just for 'mini biography'.

Please upgrade with pip install git+https://github.com/cinemagoer/cinemagoer (be sure that imdb.VERSION is '2023.07.01')

Sooner or later I'll try to fix all the other information.

@txtsd
Copy link

txtsd commented Jul 21, 2023

I took a look at the code in personParser.py but the XPaths and related piculet-specific code looks non-trivial to rectify for a person reading it for the first time.

Birth and Death dates, specifically, are not stored in time elements anymore, but are two li>as.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug http parsers of IMDb web pages
Projects
None yet
Development

No branches or pull requests

4 participants