Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code generation scripts with k8s v1.30 libraries #2349

Open
mtardy opened this issue Apr 19, 2024 · 0 comments
Open

Update code generation scripts with k8s v1.30 libraries #2349

mtardy opened this issue Apr 19, 2024 · 0 comments
Labels
area/ci Related to CI

Comments

@mtardy
Copy link
Member

mtardy commented Apr 19, 2024

Commit a9c509f replaced execution of deprecated scripts with k8s.io/code-generator/kube_codegen.sh. However, kube_codegen.sh doesn't generate code on its own, but rather defines helper functions. To migrate to kube_codegen.sh we'll need to call these functions from another script. Additionally, it'll change with version 1.30 of k8s libraries - that's why I opted to simply revert the change for now. When k8s libraries are updated to 1.30, the code generation scripts should be updated too.

_Originally posted by @lambdanis in #2339

@mtardy mtardy added the area/ci Related to CI label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to CI
Projects
None yet
Development

No branches or pull requests

1 participant