Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_name label to metrics #2214

Open
lambdanis opened this issue Mar 12, 2024 · 0 comments
Open

Add node_name label to metrics #2214

lambdanis opened this issue Mar 12, 2024 · 0 comments
Labels
area/metrics Related to prometheus metrics area/userspace Related to userspace Tetragon logic

Comments

@lambdanis
Copy link
Contributor

lambdanis commented Mar 12, 2024

Currently metrics exposed by Tetragon don't have a label with the node name. node label is added by a relabeling in the default ServiceMonitor. This works well enough, however:

  • In deployments not using the default ServiceMonitor, users have to manually configure scrape config to add such relabeling.
  • In some deployments (non-k8s in particular) node name might be not available to Prometheus at the scrape time.
  • node label on metrics might end up being different than node_name field in JSON events.
  • It's always nice to have metrics labels matching events fields.

So I'm suggesting to add node_name label to all metrics exposed by Tetragon - it should be retrieved in the same way as node_name in events.

@lambdanis lambdanis added area/metrics Related to prometheus metrics area/userspace Related to userspace Tetragon logic labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Related to prometheus metrics area/userspace Related to userspace Tetragon logic
Projects
None yet
Development

No branches or pull requests

1 participant