Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH building action followups #25

Open
1 of 5 tasks
kkourt opened this issue Nov 2, 2022 · 0 comments
Open
1 of 5 tasks

GH building action followups #25

kkourt opened this issue Nov 2, 2022 · 0 comments

Comments

@kkourt
Copy link
Collaborator

kkourt commented Nov 2, 2022

Followups items for #23

  • write a GH action that pushes tags whenever something is pushed in main or in other branches (e.g., v0.1). The idea is to use the tags under versions/ that are generated from the build action to tag these versions.
  • avoid building root images every time. We should build root images only when the image configuration changes. We can have an actions that creates a file with string to a /etc/lvh-version version in the configuration for only triggering rebuilds by modifying the string.
  • write some tests for the resulting images. We can, for example, ensure that all the images exist in the query repo and/or boot a simple VM to check basic functionality such as ssh/DNS/etc.
  • Add an expiration date to the images we generate for PRs. Currently, we tag every image so that the images will not go away. It would be good if we could attach an expiration date to these tags (see https://access.redhat.com/documentation/en-us/red_hat_quay/3/html/use_red_hat_quay/working_with_tags). To do that, however, we would need a way to tag images that we use so that they persist after the expiration date. (see point 1).
  • have a way for users to easily identify whether the images are build (e.g., a comment in the PR with the GH actions link or some label)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant