Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service cache: populate OldEndpoints when merging information from remote clusters #26176

Closed
giorio94 opened this issue Jun 13, 2023 · 5 comments · Fixed by #26474
Closed

Service cache: populate OldEndpoints when merging information from remote clusters #26176

giorio94 opened this issue Jun 13, 2023 · 5 comments · Fixed by #26474
Assignees
@akstron
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. help-wanted Please volunteer for this by adding yourself as an assignee! kind/feature This introduces new functionality. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.

Comments

@giorio94
Copy link
Member

#25687 added an OldEndpoints field to the ServiceEvent, which is currently set to the same values as Endpoints when merging information from remote clusters. This followup issue proposes to compute and propagate the appropriate OldEndpoints value also in those cases, for consistency if it was needed to be relied upon. See #25687 (comment) for additional details.
@giorio94 giorio94 added help-wanted Please volunteer for this by adding yourself as an assignee! good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/feature This introduces new functionality. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. area/clustermesh Relates to multi-cluster routing functionality in Cilium. labels Jun 13, 2023
@giorio94 giorio94 mentioned this issue Jun 13, 2023
Merged
@joestringer
Copy link
Member

Should we just delete the field for now if it's not reliable?

@giorio94
Copy link
Member Author

The field is currently populated and used when handling endpoint/endpointslice updates in the local cluster. This issue refers only to merging the information from remote clusters (AFAIU OldEndpoints is not used in that case, except maybe for external workloads if any service with endpoints outside of the cluster is present). Sorry if that wasn't clear from the original description.

@akstron
Copy link
Contributor

akstron commented Jun 17, 2023

Hi, I would like to work on this issue. Kindly assign it to me. Thanks

@swastik959
Copy link

@giorio94 hi I want to work on this issue can you please guide me through this

@giorio94
Copy link
Member Author

Thanks to both! I've assigned this issue to @akstron, who asked first. If you have any questions, we are happy to help you on the #development channel on Cilium Slack.

@akstron akstron mentioned this issue Jun 25, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akstron akstron

Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. help-wanted Please volunteer for this by adding yourself as an assignee! kind/feature This introduces new functionality. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Computed and propagated the value of OldEndpoints field when merging … akstron/cilium
4 participants
@joestringer @giorio94 @swastik959 @akstron