Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The validation button is still too small #185

Open
ZerooCool opened this issue Nov 18, 2019 · 8 comments
Open

The validation button is still too small #185

ZerooCool opened this issue Nov 18, 2019 · 8 comments

Comments

@ZerooCool
Copy link
Contributor

Change the CSS so that the validation button (at the bottom of the page) can display all the text content.

@lgarron
Copy link
Collaborator

lgarron commented Nov 19, 2019

Could I ask you to provide a screenshot so we know what needs fixing?

@ZerooCool
Copy link
Contributor Author

ZerooCool commented Nov 20, 2019

1920 x 1080 for my resolution.

I can't make a screenshot because validation is pending.

This last button is not wide enough and the font must be reduced, otherwise the text is not displayed correctly, and some of the text is truncated.

I have found the issue : #170
2 button need to be update, not only the first.

@XhmikosR
Copy link
Contributor

@ZerooCool you should submit a PR :)

@ZerooCool
Copy link
Contributor Author

For the button at the bottom, this is better :

Replace max-width: 22em; by max-width: 25em;

Please, add this in a PR.

@XhmikosR
Copy link
Contributor

I'm not sure the solution is to increase the button width. Instead the button text should wrap. Or even better, we should have the text separated from the button action.

@ZerooCool
Copy link
Contributor Author

It's right.
In my case, I was able to obtain a correct rendering with my proposal.
Separating the text (URL it seems to me) from the button is actually a very good thing.

@XhmikosR
Copy link
Contributor

Increasing the width is not right and it's moot since domains can have a big length. The proper solution would be to untie the button for the text.

@ZerooCool
Copy link
Contributor Author

Yes quite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants