Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard font "system-ui" for body to style.css #175

Open
1jj opened this issue May 17, 2019 · 2 comments
Open

Add standard font "system-ui" for body to style.css #175

1jj opened this issue May 17, 2019 · 2 comments

Comments

@1jj
Copy link

1jj commented May 17, 2019

https://hstspreload.org/static/css/style.css has this font stack:
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Helvetica, Arial, sans-serif;

I propose to change it to this:
font-family: system-ui, "-apple-system", "Segoe UI", Roboto, "Helvetica Neue", Helvetica, Arial, sans-serif;

Because system-ui is the standard version of prefixed BlinkMacSystemFont and -apple-system. It is implemented since Chrome 56:
https://www.chromestatus.com/feature/5640395337760768
and also in Safari 11:
https://caniuse.com/#feat=font-family-system-ui

As good web citizens you should use the standard way and ideally drop the prefixed fonts (may be too early for Safari to drop the apple prefix?)

@nharper
Copy link
Collaborator

nharper commented May 17, 2019

Feel free to send a pull request with that change.

@XhmikosR
Copy link
Contributor

Just keep in mind that this change was aiming at the best compatibility (I was the one who made the change to the native font stack). I made #177 where I added Noto Sans, so feel free to make a PR to propose your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants