{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":90301420,"defaultBranch":"main","name":"crashpad","ownerLogin":"chromium","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-04T19:20:25.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/30044?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1710371134.0","currentOid":""},"activityList":{"items":[{"before":"6af42bc0b22b732fdcebe9f706204e5fb229b209","after":"cd0b7c2cd47b8424ff9f29e1ea8ff97af961fe9e","ref":"refs/heads/main","pushedAt":"2024-05-21T16:06:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"infra: Move crashpad ci/try builds from Ubuntu-18.04 to Ubuntu-22.04\n\nThese are the last remaining jobs on the last remaining bionic pools.\nMoving these over should let the bionic flex pool finally be decommed.\n\nAll of chrome/chromium has been on Ubuntu-22.04 for months now. So\nhopefully this is transparent for crashpad.\n\nBug: chromium:40255350\nChange-Id: I82828c0ae0c6efc8868b33779d7ebf5fb9b16116\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5550958\nCommit-Queue: Ben Pastene \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"infra: Move crashpad ci/try builds from Ubuntu-18.04 to Ubuntu-22.04"}},{"before":"efd29a76c9462f4a555c84bdeecc7388e07184ac","after":"6af42bc0b22b732fdcebe9f706204e5fb229b209","ref":"refs/heads/main","pushedAt":"2024-05-17T16:47:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Use NOTREACHED_IN_MIGRATION()\n\nThis was generated by replacing \" NOTREACHED()\" with\n\" NOTREACHED_IN_MIGRATION()\" and running git cl format.\n\nThis prepares for making NOTREACHED() [[noreturn]] alongside\nNotReachedIsFatal migration of existing inventory.\n\nBug: chromium:40580068\nChange-Id: Idb68e2fc8adba180350b0595fd494cf0f206bded\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5548246\nReviewed-by: Mark Mentovai \nCommit-Queue: Peter Boström ","shortMessageHtmlLink":"Use NOTREACHED_IN_MIGRATION()"}},{"before":"d588c50b16f735b0c069538651d06bdd9490c6f3","after":"efd29a76c9462f4a555c84bdeecc7388e07184ac","ref":"refs/heads/main","pushedAt":"2024-05-17T00:19:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll crashpad/third_party/mini_chromium/mini_chromium/ a6607b1fd..5856e1ea6 (2 commits)\n\nhttps://chromium.googlesource.com/chromium/mini_chromium/+log/a6607b1fd76b..5856e1ea610f\n\n$ git log a6607b1fd..5856e1ea6 --date=short --no-merges --format='%ad %ae %s'\n2024-05-16 pbos Add NOTREACHED_IN_MIGRATION()\n2024-05-11 pwjworks Remove workaround for missing std::atomic_thread_fence\n\nCreated with:\n roll-dep crashpad/third_party/mini_chromium/mini_chromium\n\nBug: chromium:40580068\nChange-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5544927\nCommit-Queue: Peter Boström \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Roll crashpad/third_party/mini_chromium/mini_chromium/ a6607b1fd..585…"}},{"before":"0e043ccf70b355d8a4e08af81ca75e8c04cfe4a1","after":"d588c50b16f735b0c069538651d06bdd9490c6f3","ref":"refs/heads/main","pushedAt":"2024-05-16T22:35:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[ScopedSpinGuard] Use std::atomic::compare_exchange_strong() for spinlock\n\nPreviously, ScopedSpinGuard used std::atomic::compare_exchange_weak()\nin a loop to implement a spinlock. After looping for the specified\nnumber of nanoseconds, it would give up and return an error.\n\nA few bugs have come in on ARM platforms (https://crbug.com/340980960,\nhttp://b/296082201) which indicate that this can fail even in\nsingle-threaded cases where nothing else has the spinlock.\n\nFrom https://cbloomrants.blogspot.com/2011/07/07-14-11-compareexchangestrong-vs.html :\n\n> compare_exchange_weak exists for LL-SC (load linked/store\n> conditional) type architectures (Power, ARM, basically everything\n> except x86), because on them compare_exchange_strong must be\n> implemented as a loop, while compare_exchange_weak can be\n> non-looping.\n\nand:\n\nhttps://en.cppreference.com/w/cpp/atomic/atomic/compare_exchange#Notes\n\n> compare_exchange_weak is allowed to fail spuriously, that is, acts\n> as if *this != expected even if they are equal. When a\n> compare-and-exchange is in a loop, compare_exchange_weak will yield\n> better performance on some platforms.\n>\n> When compare_exchange_weak would require a loop and\n> compare_exchange_strong would not, compare_exchange_strong is\n> preferable [...]\n\nMy conclusion is that this logic needs to use\n`compare_exchange_strong` to avoid spurious failures on ARM in the\ncommon case when there's no other thread holding the spinlock.\n\nChange-Id: I2a08031db6b219d7d14a5cd02b3634985f81ab06\n\nBug: b:340980960\nChange-Id: I2a08031db6b219d7d14a5cd02b3634985f81ab06\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5545257\nReviewed-by: Mark Mentovai \nCommit-Queue: Ben Hamilton ","shortMessageHtmlLink":"[ScopedSpinGuard] Use std::atomic::compare_exchange_strong() for spin…"}},{"before":"aef83033716bf46eae7bb371d38faf4482acdd05","after":"0e043ccf70b355d8a4e08af81ca75e8c04cfe4a1","ref":"refs/heads/main","pushedAt":"2024-05-16T16:31:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Add guard pages to test stacks\n\nBug: b:340659332\nChange-Id: I4c2c82a1868d7a4f4a062a4e7a64258deedfb794\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5542248\nReviewed-by: Mark Mentovai \nCommit-Queue: Joshua Peraza ","shortMessageHtmlLink":"Add guard pages to test stacks"}},{"before":"4f99326c2ed8fa18f2f971d470b4b7d387212d7e","after":"aef83033716bf46eae7bb371d38faf4482acdd05","ref":"refs/heads/main","pushedAt":"2024-05-15T19:43:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix format issue\n\nChange-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5542412\nReviewed-by: Mark Mentovai \nCommit-Queue: Arthur Wang ","shortMessageHtmlLink":"Fix format issue"}},{"before":"1174aa4fc3196f478b5b4b77fc970d1cb85cb7cf","after":"4f99326c2ed8fa18f2f971d470b4b7d387212d7e","ref":"refs/heads/main","pushedAt":"2024-05-14T00:23:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Replace std::unique_ptr with base::HeapArray in process_memory.cc\n\nBug: crashpad:326459219\nChange-Id: Ic5e252285ed1fb1769eef67ddaea00a830d0ee6a\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5535006\nReviewed-by: Mark Mentovai \nCommit-Queue: Arthur Wang ","shortMessageHtmlLink":"Replace std::unique_ptr with base::HeapArray in process_memory.cc"}},{"before":"9032284170d638e514990d6878515ccdb6e6f606","after":"1174aa4fc3196f478b5b4b77fc970d1cb85cb7cf","ref":"refs/heads/main","pushedAt":"2024-05-10T19:41:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Add build/build_config.h in capture_memory.cc\n\nChange-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5531439\nCommit-Queue: Arthur Wang \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Add build/build_config.h in capture_memory.cc"}},{"before":"981d4189aa28473edf681b8d4ac1050a78a39f3c","after":"9032284170d638e514990d6878515ccdb6e6f606","ref":"refs/heads/main","pushedAt":"2024-05-10T18:23:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Pull latest Fuchsia toolchain\n\nChange-Id: Ia328c6defc59fc06fcf69a2875a0eed335c8dd78\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5532142\nCommit-Queue: Arthur Wang \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Pull latest Fuchsia toolchain"}},{"before":"371083179b7b3bc68dc8ff03ac235717805c78bd","after":"981d4189aa28473edf681b8d4ac1050a78a39f3c","ref":"refs/heads/main","pushedAt":"2024-05-09T22:27:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Replace std::unique_ptr with HeapArray\n\nBug: crashpad: 326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694\nChange-Id: I04724530cbef50a8d3c18f306d16c0bbf3b0815b\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5512394\nReviewed-by: Mark Mentovai \nCommit-Queue: Arthur Wang ","shortMessageHtmlLink":"Replace std::unique_ptr<T> with HeapArray"}},{"before":"8e60a935d981566e4b2e6345ad6c7e2f2dc6849a","after":"371083179b7b3bc68dc8ff03ac235717805c78bd","ref":"refs/heads/main","pushedAt":"2024-05-09T18:59:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"ios: Use correct address when storing register memory.\n\nThe memory region data saved in the intermediate dump is an address\noffset by 128 bytes. However, the MemorySnapshot generated was using the\noriginal address and not the offset address. The same data is being\ncaptured in the minidump.\n\nChange-Id: Ia34912c035319e79cf446a130e662084f4ab51ea\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5529059\nCommit-Queue: Justin Cohen \nReviewed-by: Joshua Peraza \nReviewed-by: Rohit Rao ","shortMessageHtmlLink":"ios: Use correct address when storing register memory."}},{"before":"5c09c9a701b6b7d5e00db1a57c751aa48e7e633c","after":"8e60a935d981566e4b2e6345ad6c7e2f2dc6849a","ref":"refs/heads/main","pushedAt":"2024-05-07T18:27:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll mini_chromium to remove the pointer-based overload of RandBytes()\n\nR=mark@chromium.org\n\nBug: 40284755\nChange-Id: I2f491cc3f630767e607ea1df7d21791be522b4de\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5518909\nReviewed-by: Mark Mentovai \nCommit-Queue: danakj ","shortMessageHtmlLink":"Roll mini_chromium to remove the pointer-based overload of RandBytes()"}},{"before":"84c87739e837f4ec9ce26f32f693e3dddd6494ad","after":"5c09c9a701b6b7d5e00db1a57c751aa48e7e633c","ref":"refs/heads/main","pushedAt":"2024-05-06T15:09:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Include build_config.h before checking COMPILER_MSVC\n\nThis is caught by chromium presubmit when rolling crashpad.\n\nR=mark@chromium.org\n\nChange-Id: Ida9ff07e7b2bd27808c092afbc5a1345fa29a4f3\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5515300\nReviewed-by: Mark Mentovai \nCommit-Queue: danakj ","shortMessageHtmlLink":"Include build_config.h before checking COMPILER_MSVC"}},{"before":"bff987324242ec1c67d57e1228e3d428cce4882c","after":"84c87739e837f4ec9ce26f32f693e3dddd6494ad","ref":"refs/heads/main","pushedAt":"2024-05-06T14:17:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Use the span version of RandBytes\n\nSome unique_ptr are also changed to HeapArray in order to\nfacilitate the change.\n\nBug: chromuim: 40284755\nChange-Id: I30b9d55ff81f23c63ad4958786740f67ee612024\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5512569\nReviewed-by: Mark Mentovai \nCommit-Queue: danakj ","shortMessageHtmlLink":"Use the span version of RandBytes"}},{"before":"da189353b60611dd7089aa2a14441893460ebcdb","after":"bff987324242ec1c67d57e1228e3d428cce4882c","ref":"refs/heads/main","pushedAt":"2024-05-03T23:27:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Make NTSTATUS_LOG less likely to change ::GetLastError() value\n\nThis better ensures that using code like\n`NTSTATUS_LOG(ERROR, status) << ::GetLastError()` would print the\nintended value. This isn't done today by the code AFAICT, but\nmaking this change primarily for consistency with the change to\nChromium logging in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/5443628\n\nBug: chromium:333445539\nChange-Id: I49f16b9ed78d98a0b2f178f58465002aad757ae5\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5474027\nReviewed-by: Mark Mentovai \nCommit-Queue: Andrew Williams ","shortMessageHtmlLink":"Make NTSTATUS_LOG less likely to change ::GetLastError() value"}},{"before":"dc489055ed8ecb1eb3fb8e22a7a4c5c4d9b1459e","after":"da189353b60611dd7089aa2a14441893460ebcdb","ref":"refs/heads/main","pushedAt":"2024-05-03T21:43:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Replace std::is_pod usage\n\nReplacing std::is_pod usage as per the following compilation error:\n```\n../../util/misc/uuid.cc:44:20: error: 'is_pod' is deprecated: use 'is_standard_layout && is_trivial' instead [-Werror,-Wdeprecated-declarations]\nstatic_assert(std::is_pod::value, \"UUID must be POD\");\n ^\n/usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/type_traits:818:5: note: 'is_pod' has been explicitly marked deprecated here\n _GLIBCXX20_DEPRECATED_SUGGEST(\"is_standard_layout && is_trivial\")\n\n```\n\nBug: None\nChange-Id: I1d61ee12261877f7f1f84f0ea15d262d22959766\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5472885\nCommit-Queue: Andrew Williams \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Replace std::is_pod usage"}},{"before":"76badd4c20acdd9f06f269a5566cc3f6a095f265","after":"dc489055ed8ecb1eb3fb8e22a7a4c5c4d9b1459e","ref":"refs/heads/main","pushedAt":"2024-05-02T17:33:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix incorrect DCHECK in CET contexts\n\nThis DCHECK() was not correct. When dumping a process with CET\nenabled the cetumsr and cetussp registers are not available in\nthe context obtained for the exception record. All contexts to be\nwritten to a minidump must have the same context format so those\nregisters will be present for captured threads. It is therefore ok for\nthe context to expect extended xsave registers but for them to be\nzero in some cases.\n\nBug: 337665168\nChange-Id: If7e5f40fe8eda6799b034991cb87e89437cb4821\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5507588\nReviewed-by: Mark Mentovai \nCommit-Queue: Alex Gough ","shortMessageHtmlLink":"Fix incorrect DCHECK in CET contexts"}},{"before":"7e0af1d4d45b526f01677e74a56f4a951b70517d","after":"76badd4c20acdd9f06f269a5566cc3f6a095f265","ref":"refs/heads/main","pushedAt":"2024-05-02T16:15:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Replace std::unique_ptr with HeapArray in process_info.cc and\nprocess_info_test.cc\n\nBug: crashpad: 326459035,326458915,326459055\nChange-Id: Ifb91297b6097aa81a9d5c883b2c284e9fdd512a8\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5463361\nReviewed-by: Mark Mentovai \nCommit-Queue: Arthur Wang ","shortMessageHtmlLink":"Replace std::unique_ptr<T[]> with HeapArray in process_info.cc and"}},{"before":"8df174c64ca2b9dc0f83b089d30760867966b173","after":"7e0af1d4d45b526f01677e74a56f4a951b70517d","ref":"refs/heads/main","pushedAt":"2024-04-11T17:46:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Use byte conversions over the byte swap functions\n\nbase/sys_byteorder.h is going away. Instead, use the byte conversions\nin base::numerics to convert from a byte array in big endian to an\ninteger. This avoids putting big endian data into integer types at all.\n\nmini_chromium was rolled and crashpad updated to work with newer\nmac/windows toolchains in order to support C++20 in\nf9cee5c147db30dc8fa1a048aabd165965b5cb60.\n\nBug: 40284755\nChange-Id: If690847b7aa54b0216e73ec297eae3d0bca2fa57\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5402184\nCommit-Queue: danakj \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Use byte conversions over the byte swap functions"}},{"before":"f9cee5c147db30dc8fa1a048aabd165965b5cb60","after":"8df174c64ca2b9dc0f83b089d30760867966b173","ref":"refs/heads/main","pushedAt":"2024-04-11T17:19:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[ios] Fix TSAN issue and Mach port leak in CrashpadClient\n\nThere were two issues with the iOS implementation of CrashpadClient\nwhich I reported in https://crbug.com/crashpad/481:\n\n1) TSAN found a data race in ResetForTesting() when it modified the\nScopedMachReceiveRight while the Mach exception port thread was\nreading it\n\n2) The Mach port connected to the exception server was never deallocated\n\nThis CL fixes both issues.\n\nChange-Id: I5bd4f79ae6d0eccca954d663be7a36f8ceb0a0e8\nBug: https://crbug.com/crashpad/481\nBug: b:332305593\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5410301\nReviewed-by: Mark Mentovai \nCommit-Queue: Justin Cohen ","shortMessageHtmlLink":"[ios] Fix TSAN issue and Mach port leak in CrashpadClient"}},{"before":"bbb99bfa3766f06dcfe8f72a9379c59e5a44b43b","after":"f9cee5c147db30dc8fa1a048aabd165965b5cb60","ref":"refs/heads/main","pushedAt":"2024-04-11T16:25:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll mini_chromium to pick up the latest version of base::span.\n\nAlso enables C++20 as span now depends on it.\n\nRoll buildtools to grab a newer libc++ that supports C++20.\n\nExplicitly capture `this` in lambdas in cpp-httplib as the implicit\ncapture through `=` is deprecated and causes an error in C++20.\n\nUpdate the MacOS version to \"Mac-13|Mac-14\" which is the current\nvalue of `os.MAC_DEFAULT` in Chromium infra in order to have\nC++20 support in the std library on iOS.\n\nMoves iOS tests to run on iPhone 13 and includes a mini_chromium roll\nto fix Xcode 14.3 egtests.\n\nBug: 40284755\nChange-Id: Ic078f07d12473f2aaed5e84df0f0a7fb7b8c35c3\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5443384\nCommit-Queue: Justin Cohen \nReviewed-by: danakj ","shortMessageHtmlLink":"Roll mini_chromium to pick up the latest version of base::span."}},{"before":"1cea0473a5a1f3124f0d3a95643c573296a2bac5","after":"bbb99bfa3766f06dcfe8f72a9379c59e5a44b43b","ref":"refs/heads/main","pushedAt":"2024-04-04T20:14:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Move crashpad to using Mac-13|Mac-14 (like chromium) and latest win sdk\n\nThis should give crashpad a newer xcode and msvc that support C++20.\n\nThese changes need to land separately from the C++20 usage, as they do\nnot get applied until after landing, so can't affect the CQ from inside\nthe CQ.\n\nBug: 40284755\nChange-Id: I3ae72befa008bfb37bac882de0986c5bcf9de079\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5425460\nCommit-Queue: danakj \nReviewed-by: Mark Mentovai ","shortMessageHtmlLink":"Move crashpad to using Mac-13|Mac-14 (like chromium) and latest win sdk"}},{"before":"ccd20652bc4c7b9ab1878f5dcc0886d40d9a17c9","after":"1cea0473a5a1f3124f0d3a95643c573296a2bac5","ref":"refs/heads/main","pushedAt":"2024-03-21T20:32:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"ios: Capture signal exception context memory regions correctly.\n\nPreviously, Crashpad would only capture iOS thread context memory regions by iterating the task_threads->thread_get_state's. For Mach\nexception this worked as intended. However, for signal exceptions this\nmissed the registers from the actual signal context. This change\ncorrectly captures these regions and stores them in the exception\nsnapshot.\n\nChange-Id: I494e753a25c2687e61b5183ed0135f520ca8bf52\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5380505\nReviewed-by: Mark Mentovai \nCommit-Queue: Justin Cohen ","shortMessageHtmlLink":"ios: Capture signal exception context memory regions correctly."}},{"before":"6bf5e1b5c5038eaefd812f0027ff011153ae30c9","after":"ccd20652bc4c7b9ab1878f5dcc0886d40d9a17c9","ref":"refs/heads/main","pushedAt":"2024-03-18T18:44:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"ios: Update exception test for Chromium release builds.\n\nAfter https://crrev.com/c/5375084, Chromium __libcpp_verbose_abort is\nhandled differently for official non-dcheck builds. This change fixes\nthe test expectation for release non-official builds.\n\nBug: 330168249\nChange-Id: Iceb6d327f9e93fd366cc07abe27eefd1adf06472\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5378380\nReviewed-by: Mark Mentovai \nCommit-Queue: Justin Cohen ","shortMessageHtmlLink":"ios: Update exception test for Chromium release builds."}},{"before":"c4d4a4d83e864df270c267888176ffa415a599b0","after":"6bf5e1b5c5038eaefd812f0027ff011153ae30c9","ref":"refs/heads/main","pushedAt":"2024-03-15T14:14:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix invalid check for valid key of Pointer Authentication\n\nArm's Pointer Authentication uses two keys for signing pointers, A-key\nand B-key. Although by default Clang uses the A-key if PAC support is\nenabled at compile time, this behaviour might be overridden via compiler\ncommand line.\n\nThis CL fixes the check for the B-key being enabled. The key that shall\nbe used for Pointer Authentication is denoted by bits 0 (A-key) or\n1 (B-key) of __ARM_FEATURE_PAC_DEFAULT. Hence, the previous way of\nchecking by using bits 0 and 2 does not correctly identify the B-key.\n\nBug: 40608466\nChange-Id: Ib2f226baa12a7145fa0b6e486e49d36e6b0a3cd7\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5341090\nReviewed-by: Mark Mentovai \nCommit-Queue: Mark Mentovai ","shortMessageHtmlLink":"Fix invalid check for valid key of Pointer Authentication"}},{"before":"49cf086467892e3bff693705d84959ac50e02d79","after":null,"ref":"refs/heads/dependabot/go_modules/doc/appengine/google.golang.org/protobuf-1.33.0","pushedAt":"2024-03-13T23:05:34.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"}},{"before":null,"after":"49cf086467892e3bff693705d84959ac50e02d79","ref":"refs/heads/dependabot/go_modules/doc/appengine/google.golang.org/protobuf-1.33.0","pushedAt":"2024-03-13T22:50:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /doc/appengine\n\nBumps google.golang.org/protobuf from 1.30.0 to 1.33.0.\n\n---\nupdated-dependencies:\n- dependency-name: google.golang.org/protobuf\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /doc/appengine"}},{"before":"9c58b668ff3372448b1c2ef6e1f3c34930825862","after":"c4d4a4d83e864df270c267888176ffa415a599b0","ref":"refs/heads/main","pushedAt":"2024-03-08T22:56:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"ios: Disable annotations tests on older simulators on macOS 14.3\n\nThere appears to be a change in dyld in macOS 14.3 that iOS 17\naccounts for, but older simulators do not. This causes the main\nbinary to be listed twice when iterating modules, breaking some\ntests.\n\nBug: crbug.com/328282286\n\nChange-Id: I71909fbc13bee6de23b10ffd92a791067f8ea909\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5353754\nReviewed-by: Mark Mentovai \nCommit-Queue: Justin Cohen ","shortMessageHtmlLink":"ios: Disable annotations tests on older simulators on macOS 14.3"}},{"before":"bc4fd34fe2e2611689f0a947885a11a16bd122cd","after":"9c58b668ff3372448b1c2ef6e1f3c34930825862","ref":"refs/heads/main","pushedAt":"2024-03-07T22:39:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Increase kMaxNumberOfAnnotations\n\nChrome on ChromeOS is starting to run into problems where there are more\nthan 200 annotations, primarily because we use a lot of command-line\nswitches (40 or more) and commandline-enabled-features as well, each of\nwhich takes up an annotation. It's still rare (100s a day) but will\nprobably become worse over time as more CrashKey uses are added.\n\nIncrease kMaxNumberOfAnnotations to 400.\n\nBUG=296821415\n\nChange-Id: Iba7049014ee3c5ae9c45c4022600eaba50acd403\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5354336\nReviewed-by: Mark Mentovai \nCommit-Queue: Ian Barkley-Yeung \nReviewed-by: Joshua Peraza ","shortMessageHtmlLink":"Increase kMaxNumberOfAnnotations"}},{"before":"37afd37401253ebcebcf6e07ce15c8cfecb1a1cc","after":"bc4fd34fe2e2611689f0a947885a11a16bd122cd","ref":"refs/heads/main","pushedAt":"2024-02-22T19:45:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Log argv[0] for failing spawns\n\nThis adds argv[0] for PLOG(FATAL) calls following a failed posix_spawn\nor execve call to make logs more useful.\n\nBug: chromium:324982367\nChange-Id: I179928ec9f791ce5b365b3444aa3bb667f4ec4b3\nReviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5315332\nReviewed-by: Mark Mentovai \nCommit-Queue: Peter Boström ","shortMessageHtmlLink":"Log argv[0] for failing spawns"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUA0DWAA","startCursor":null,"endCursor":null}},"title":"Activity · chromium/crashpad"}