Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Support #65

Open
DaJoTo opened this issue Dec 9, 2020 · 7 comments
Open

PHP 8 Support #65

DaJoTo opened this issue Dec 9, 2020 · 7 comments

Comments

@DaJoTo
Copy link

DaJoTo commented Dec 9, 2020

Is there any chance you can bump require version to support PHP 8?

It's great that you've made things compatible with with Laravel 8, perhaps something in keeping with their approach ("^7.4|^8.0")?

Thanks for the hard work on this package, love it. Not a fan of the Laravel 8 factories approach.

@christophrumpel
Copy link
Owner

Hey @DaJoTo, thanks for the reminder and that you like the package. Still on my list. Will give it a look 👍

@christophrumpel
Copy link
Owner

Ok I took a look today. One problem is that I use BetterReflection for this package which does not have PHP 8 support yet.
Roave/BetterReflection#701

I might have to wait until they release a new version.

@DaJoTo
Copy link
Author

DaJoTo commented Dec 9, 2020

Looks like someone has done most of the work already, just needs PRing and ensuring it doesn't break tests. I'll see if I can invest some time into it.

@christophrumpel
Copy link
Owner

Just checked, still no PHP8 support for BetterReflection package =/

@EranNL
Copy link
Contributor

EranNL commented Mar 29, 2022

@christophrumpel There is a php 8 update now. Are you willing to upgrade yours or did you abandon the development?

@christophrumpel
Copy link
Owner

Hey, I dont use it myself anymore but Im willing to upgrade with some help. Would you do a PR?

@EranNL
Copy link
Contributor

EranNL commented Mar 30, 2022

Sure! I just opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants