Fix use of check_zero() in forceNetwork() and sankeyNetwork()
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `check_zero()` too early in the function resulted in a bug where 1-indexed input would not be detected if either: * `Links` was not a `data.frame` * `Source` or `Target` were missing Moving `check_zero()` further down the functions and adding missing input checks for `forceNetwork()` fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281
Calling
check_zero()too early in the function resulted in a bug where 1-indexed input would not be detected if either:Linkswas not adata.frameSourceorTargetwere missingMoving
check_zero()further down the functions and adding missing input checks forforceNetwork()fixes the issue.