Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sankey node tooltip has invalid html <br> tag instead of \n #146

Closed
mac471 opened this issue Aug 30, 2016 · 5 comments
Closed

Sankey node tooltip has invalid html <br> tag instead of \n #146

mac471 opened this issue Aug 30, 2016 · 5 comments

Comments

@mac471
Copy link

mac471 commented Aug 30, 2016

First, this is a great package! Thanks for putting it together!

For the tooltips on sankey nodes (rect objects), the text uses <br> to signify a new line when I believe it should be using \n instead.

Is this something that can get fixed in the next release?

@christophergandrud
Copy link
Owner

I think there is an open pull request that attempts to address this #130. Any help with that would be great.

@mac471
Copy link
Author

mac471 commented Aug 31, 2016

Thanks for your note and for pointing me in the direction of the post where
this was also raised. I didn¹t realize that this was a Mac/Windows issue as
well.

I¹ll take a look at ivot¹s solution when I have a moment and will see if I
can help.

@christophergandrud
Copy link
Owner

Great, thanks.

@fbreitwieser
Copy link

fbreitwieser commented Sep 12, 2016

I have this issue, too (on Linux with Chromium). Note that for the edges, it is still '\n' (line 173, which works for me), and just for nodes it's <br> (line 184, which shows up as <br> for me).

@daattali
Copy link

I made a new tiny PR for this issue #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants