Adapt is_vim so that it works with .vim-wrapped on NixOS #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kranich
force-pushed
the
support-detection-of-vim-wrapped
branch
2 times, most recently
from
342a3de
to
3447099
Compare
|
Hey @kranich -- happy to make the change here. I appreciate the notes and thinking. Would you mind updating the README to mirror the changes you made in the TPM file? Ideally those two would match each other. |
kranich
force-pushed
the
support-detection-of-vim-wrapped
branch
from
3447099
to
61b278e
Compare
|
Thank you! I have updated I will also prepare pull requests on the NixOS side of things to upgrade the plugin versions once this is merged. |
|
@christoomey ready when you are! ;-) |
vim on NixOS presents itself as `.vim-wrapped` which was not covered in the regexp of `is_vim`.
kranich
force-pushed
the
support-detection-of-vim-wrapped
branch
from
d94f16a
to
743f1e8
Compare
|
@christoomey May I try to remind you of this open pull request? You seem to have forgotten about it, but I would still like to get it merged, if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim on NixOS presents itself as
.vim-wrappedwhich was not covered in the regexp ofis_vim.Fixes #264.
Given the increasing adoption of NixOS as compared to in 2017, would you please reconsider your statement at #171 (comment) and be so kind as to accept this merge request?