Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy Retries Example #12

Open
jrnt30 opened this issue Dec 13, 2017 · 2 comments
Open

Envoy Retries Example #12

jrnt30 opened this issue Dec 13, 2017 · 2 comments

Comments

@jrnt30
Copy link

jrnt30 commented Dec 13, 2017

Currently the http://blog.christianposta.com/istio-workshop/slides/#/43 directs the user to patch the simple.json with the retry semantics, however this is already present.

Suggested edits:

  • Remove the retry from simple.json to start
  • Provide users an example where they attempt to generate the 500
  • Have users look at retries (that don't exist)
  • Have users patch simple.json (as suggested is necessary by the slides)
  • Show users retry
@jwendell
Copy link
Contributor

Proposed fix in #4

@christian-posta
Copy link
Owner

Yah -- i like that flow @jrnt30 -- will make some updates for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christian-posta @jwendell @jrnt30