Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options refactoring #54

Open
2 tasks
GMartigny opened this issue Jan 20, 2020 · 0 comments
Open
2 tasks

Options refactoring #54

GMartigny opened this issue Jan 20, 2020 · 0 comments

Comments

@GMartigny
Copy link
Collaborator

Information

  • Your current node version: v13.6.0
  • The package version you used: 10.2.0

Description

A few things are wrong with the way we handle options on the plugins.

  • Options are checked before being passed to rollup, this means that whenever the rollup API change, we have to update the plugin. Passing options directly to rollup could fix this, but maybe add unexpected behavior.
  • Input and output options are mixed together. We should align with the rollup options API. For example, this means that the plugins option is only supported for input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GMartigny