(#3381) Add new rule command #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
rule-command
branch
3 times, most recently
from
3570985
to
a8bb1e9
Compare
AdmiringWorm
force-pushed
the
rule-command
branch
from
a8bb1e9
to
e31ebb1
Compare
AdmiringWorm
force-pushed
the
rule-command
branch
from
e31ebb1
to
86135c7
Compare
gep13
reviewed
May 20, 2024
src/chocolatey/infrastructure.app/commands/ChocolateyRuleCommand.cs
Outdated
Show resolved
Hide resolved
|
@AdmiringWorm overall, this looks really good, and would be happy to get this merged in. While reviewing, I did make some changes, which I have added as a standalone commit. Let's have a chat about the changes tomorrow, and decide whether to move forward with them. |
This adds a new command called ´rule` with an alias of `rules` to be able to view any Validation Rules that have been implemented by Chocolatey CLI, or the details of a specific view. This allows a user to see what is implemented when they are packaging their Chocolatey CLI package. This is intended to be used in the future to enhance other functionality.
The Rule Service interface was missing the ability to get all available rules that have been implemented. This commit updates the interface to include this method.
There was an unused `ex` in a catch block, which goes against out coding conventions.
|
@AdmiringWorm and I met today, and during a pairing session decided that the suggested changes make sense. These have now been rebased into the existing commits, and will continue with the merge, once the CI builds pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This adds a new command called ´rule
with an alias ofrules` to be able to view any Validation Rules that have been implemented by Chocolatey CLI, or the details of a specific view.Motivation and Context
To give visibility to users an what will happen/validated when they package their Chocolatey CLI package, as well intended enhanced functionality that will be implemented outside Chocolatey CLI that can reuse this same command.
Testing
choco rules(also trychoco rule list). You should then see something similar tochoco rule get --name CHCR0002. You should then see something similar tochoco rule CHCR0002)choco rules -r. You should then see something similar tochoco rule --name missing. You should see something similar tochoco rule get --name missing. You should see something similar tochoco rule get --name CHCR0001 -r. You should see something similar as point 3, with just the specified rule outputted.choco rule get --name missing -r. No rules should be outputted, and no error occurring.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3381