Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datatables.net package breaks after 0.13.1 #315

Open
4 tasks done
st3phhays opened this issue Mar 31, 2023 · 2 comments
Open
4 tasks done

datatables.net package breaks after 0.13.1 #315

st3phhays opened this issue Mar 31, 2023 · 2 comments
Assignees
@st3phhays
Labels
Bug Tickets that represent defects/bugs. ChocolateyLicensing

Comments

@st3phhays
Copy link
Member

st3phhays commented Mar 31, 2023 •
edited by sync-by-unito bot

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.

What You Are Seeing?

When trying to use the datatables.net package on anything after 0.13.1, it results in JS errors in the console, stating that certain things are not functions.

The last known version to work is 0.13.1.

What is Expected?

We should not need to pin datatables.net to 0.13.1. Any minor version changes that are pulled in by the yarn.lock file should work.

How Did You Get This To Happen?

  1. Ran datatables.net with a resolution to 0.13.1 and everything works.
  2. Ran datatabels.net with 0.13.4 (what the yarn.lock pulls in automatically) and this results in breaking JS errors

System Details

N/A

Installed Packages

N/A

Output Log

N/A

Additional Context

Commit history, something between 0.13.1 and 0.13.4 broke: https://github.com/DataTables/DataTablesSrc/commits/1.13.4

┆Issue is synchronized with this Gitlab issue by Unito
@st3phhays st3phhays added Bug Tickets that represent defects/bugs. 0 - Backlog Where tickets start after being triaged. This means the ticket has targeted milestone/labels. labels Mar 31, 2023
@st3phhays st3phhays self-assigned this Mar 31, 2023
st3phhays added a commit to st3phhays/choco-theme that referenced this issue Apr 5, 2023
@st3phhays
(chocolatey#315) Pin datatables.net to 0.13.1
d8aecc9 
This package or our implementation of it is broken past version
0.13.1. Until we are able to figure out the exact problem, let's pin
our version to the last known working package which is 0.13.1. This
will ensure we can still update choco-theme as needed for the
time being. This is not a permanent solution.
@st3phhays st3phhays mentioned this issue Apr 5, 2023
Merged
10 tasks
@st3phhays st3phhays added this to the 0.4.x milestone Apr 5, 2023
st3phhays added a commit that referenced this issue Apr 5, 2023
@st3phhays
Merge pull request #319 from st3phhays/release/0.3.2
2bdc177 
(#308)(#314)(#315)(#316)(#317)(#318) Algolia and small style adjustments
@st3phhays st3phhays reopened this Apr 19, 2023
@st3phhays
Copy link
Member Author

A PR was merged to pin this package to the last working version, but the root cause needs to be addressed, and the version unpinned.

@sync-by-unito sync-by-unito bot removed the 0 - Backlog Where tickets start after being triaged. This means the ticket has targeted milestone/labels. label Oct 18, 2023
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Jan 2, 2024

➤ Stephanie Hays commented:

For now, let's put this issue on hold as this package may be updated in future choco-theme work related to upgrading Bootstrap and the build process.

@st3phhays st3phhays added the 0 - _Triaging New tickets that need to be hashed out a bit more before they hit the backlog. label Jan 3, 2024
@sync-by-unito sync-by-unito bot removed the 0 - _Triaging New tickets that need to be hashed out a bit more before they hit the backlog. label Jan 3, 2024
@st3phhays st3phhays removed this from the 0.5.x milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3phhays st3phhays

Labels
Bug Tickets that represent defects/bugs. ChocolateyLicensing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@st3phhays