Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Bootstrap's native ScrollSpy Component #246

Open
st3phhays opened this issue Oct 13, 2022 · 0 comments
Open

Investigate Bootstrap's native ScrollSpy Component #246

st3phhays opened this issue Oct 13, 2022 · 0 comments
Assignees
Labels
0 - Backlog Where tickets start after being triaged. This means the ticket has targeted milestone/labels. Enhancement Enhancements are things that are improvements or features.

Comments

@st3phhays
Copy link
Member

Is Your Feature Request Related To A Problem? Please describe.

In Bootstrap 5.2.2, the ScrollSpy component was rewritten to fix some underlying problems. Currently choco-theme uses a custom implementation of "ScrollSpy" because of the issue that it had a while back. Now that the issues have been fixed, it would be worth investigating whether or not we can utilize the native ScrollSpy component and remove the custom implementation.

Describe The Solution. Why is it needed?

While what we have works now, it is a good idea to utilize native features in the framework if it supplies them. This could reduce future buts and the amount of code introduced to maintain.

Additional Context.

This feature (our custom build) is currently being used in the docs, choco-design, boxstarter, company, and maybe chocolatey.org.

ScrollSpy: https://getbootstrap.com/docs/5.2/components/scrollspy/#how-it-works
Issue: twbs/bootstrap#33421

Related Issues

n/a

@st3phhays st3phhays self-assigned this Oct 13, 2022
@st3phhays st3phhays added Enhancement Enhancements are things that are improvements or features. 0 - Backlog Where tickets start after being triaged. This means the ticket has targeted milestone/labels. labels Oct 13, 2022
@st3phhays st3phhays added this to the 0.2.x milestone Jan 9, 2023
@st3phhays st3phhays removed this from the 0.5.x milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog Where tickets start after being triaged. This means the ticket has targeted milestone/labels. Enhancement Enhancements are things that are improvements or features.
Projects
None yet
Development

No branches or pull requests

1 participant