Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxstarter doesn't override 'Write-Host' when in any non-Boxstarter shell/script #561

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mwallner
Copy link
Member

Description Of Changes

Ensure Boxstarter is added to the end of PSModulePath when being installed, this way 'Write-Host' is not loaded from Boxstarter but 'Microsoft.PowerShell.Utility' (or whatever comes first)

Motivation and Context

See GH-528 - Boxstarter gets installed to top of PSModulePath and overwrites Write-Host

Testing

I've tested this via creating the Chocolatey-nupkgs using the buildscript, - it works as expected when installing/upgrading via Chocolatey as well as when using the Boxstarter.bat wrapper.

Operating Systems Testing

  • Windows 10 1809 ENT
  • Windows 11 23H2 ENT

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxstarter gets installed to top of PSModulePath and overwrites Write-Host
2 participants