Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Chocolatey scripting best practices for Boxstarter Chocolatey packages #507

Open
gep13 opened this issue Jul 14, 2022 · 0 comments
Open
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features

Comments

@gep13
Copy link
Member

gep13 commented Jul 14, 2022

Is Your Feature Request Related To A Problem? Please describe.

There are instances where scripting best practices are not being following in the packaging scripts for the Boxstarter packages. For example, in the main Boxstarter package there is:

try {
    Write-Host "To load all Boxstarter Modules immediately, just enter 'BoxstarterShell'." -ForegroundColor Yellow
    Write-Host "Interested in Windows Azure VM integration? Run CINST Boxstarter.Azure to install Boxstarter's Azure integration."
} catch {
    throw $_.exception
}

when this should be:

Write-Warning "To load all Boxstarter Modules immediately, just enter 'BoxstarterShell'." 
Write-Host "Interested in Windows Azure VM integration? Run CINST Boxstarter.Azure to install Boxstarter's Azure integration."

Describe The Solution. Why is it needed?

Follow the recommended best practices for packaging scripts.

A full audit of all the packages should be completed.

Additional Context.

N/A

Related Issues

N/A

@pauby pauby added Improvement Issues that enhances existing functionality, or adds new features 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

No branches or pull requests

2 participants