Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "office use only" style section to Pull Request templates #41

Open
2 tasks done
corbob opened this issue Dec 21, 2023 · 2 comments
Open
2 tasks done

Add a "office use only" style section to Pull Request templates #41

corbob opened this issue Dec 21, 2023 · 2 comments
Labels
0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint

Comments

@corbob
Copy link
Member

corbob commented Dec 21, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When we are accepting pull requests, there are a number of checks that we would like to keep in our minds to ensure we're not making more work for ourselves in the future. It would be good to add these to the PR template so that we can ensure they are done.

Describe The Solution. Why is it needed?

Notice on many forms there are sections labeled "For Office Use Only". The purpose of these sections is for the company to ensure that they complete various processes. Likewise adding this section to the PRs is a reminder for Chocolatey maintainers to ensure various things are covered off.

Some examples:

  • Does this PR affect other Chocolatey products that may need a corresponding change?
    • For example: Chocolatey Licensed Extension, Chocolatey GUI, Chocolatey Agent, Boxstarter(?), etc.
  • Is the PR attached to an Issue that's been attached to a milestone?
  • Do any of these changes need to be made to other branches?
    • For example: Updates to just the Pester tests likely need to be pulled into the master branch so that hotfixes are getting the full suite of tests.

Additional Context

This came up during discussion at the Engineering Team Meeting December 21, 2023 (not recorded, nor were minutes taken, was more of a standup than a regular meeting).

Related Issues

No response

@pauby
Copy link
Member

pauby commented Dec 21, 2023

Was there a PR discussed at the meeting (I know this was only 27 minutes ago but if I don't ask know I may forget later).

@corbob
Copy link
Member Author

corbob commented Dec 21, 2023

Was there a PR discussed at the meeting (I know this was only 27 minutes ago but if I don't ask know I may forget later).

We discussed PRs from the Chocolatey/choco (chocolatey/choco#3372, chocolatey/choco#3373, chocolatey/choco#3374), Chocolatey/ChocolateyGUI (chocolatey/ChocolateyGUI#1033, chocolatey/ChocolateyGUI#1034, chocolatey/ChocolateyGUI#1035), and Licensed Extension (https://gitlab.com/chocolatey/collaborators/choco-licensed/-/merge_requests/278, https://gitlab.com/chocolatey/collaborators/choco-licensed/-/merge_requests/279, https://gitlab.com/chocolatey/collaborators/choco-licensed/-/merge_requests/282) repositories.

The discussion was mostly because we realized there are scenarios where we need to make sure we're porting between branches and repositories and it's easy to miss. So adding a "for office use only" section could help us ensure we assess these things. (Kind of like the Acceptance Criteria and Done Checklist, but mainly for the merger to ensure.

@corbob corbob added the 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint
Projects
None yet
Development

No branches or pull requests

2 participants