Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics reporting StoreKit exception: SKProductsRequest handleReply #53

Open
iury opened this issue Dec 7, 2016 · 5 comments
Open

Comments

@iury
Copy link

iury commented Dec 7, 2016

Hello,

We are starting to receive the following crash report:
http://crashes.to/s/400617489c8

Any thoughts about what could be causing the issue?

@chirag04
Copy link
Owner

chirag04 commented Dec 7, 2016

are you able to replicate this locally? might be when putting the app in background?

Also:
http://stackoverflow.com/questions/24675528/ios-crash-report-skproductsrequest

@iury
Copy link
Author

iury commented Dec 7, 2016

unfortunately I'm not able to replicate. so far this affected only 2 users of 147 using the version released few hours ago. previous versions of the app weren't affected by this crash, so I'm not sure if we screwed something up or is just a random error. I'll be monitoring and will keep in touch

@iury
Copy link
Author

iury commented Dec 7, 2016

dig into the source code, the productsRequest in https://github.com/chirag04/react-native-in-app-utils/blob/master/InAppUtils/InAppUtils.m#L147 should be a strong reference, no? Apple docs at https://developer.apple.com/reference/storekit/skproductsrequest remarks "be sure to keep a strong reference to the request object; otherwise, the system might deallocate the request before it can complete."

@chirag04
Copy link
Owner

chirag04 commented Dec 7, 2016

yeah. good find. Can you send a PR?

@iury
Copy link
Author

iury commented Dec 7, 2016

#48 seems to be exact about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants