Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should be shown when compression utilities are missing #1925

Open
platomav opened this issue Sep 1, 2023 · 1 comment
Open
Assignees

Comments

@platomav
Copy link
Member

platomav commented Sep 1, 2023

Hello,

I noticed that Chipsec does not inform the user when a Tiano, LZMAF86 etc compression dependency is missing or has not been built.

So if it's forgotten by accident, it silently fails to process UEFI images with compression correctly.

I suggest an error message to be shown when a Tiano, LZMAF86 etc dependency is needed but is missing. Probably the same for LZMA, Brotli etc, but I think these are python imports, so they'll probably crash outright? If these are also ignored silently, the user should be aware.

@npmitche
Copy link
Member

npmitche commented Sep 1, 2023

It was on purpose because those packages are not present in the UEFI shell and we didn't want people to be concerned about it. With that said, it might make sense to check if you're in an OS and if you are, report a warning/error. We'll look into it.

@npmitche npmitche self-assigned this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants