You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think a number of issues could be caught at compile type by adding gradual typing annotations to chipsec. I tried using pytype on chipset.py, but it issues a lot of spurious warnings because it would need TypedDict annotations to understand the content of the various Cfg arrays (which contain heterogeneous mappings from fixed strings to various types). We could also use mytype instead, I only tried the one I'm most familiar with.
I'd be willing to put in the effort but only if there is a chance to see it merged upstream. Is this something you would be interested in?
The text was updated successfully, but these errors were encountered:
Short term, we still have to work with python 2.7 due to the EFI Shell implementation. Long term, we are actively looking at replacing this implementation with the recently added edk2-libc python 3.6.8 support. After the EFI Shell update to py3, we can look at Type Hints that work with 3.6.8.
I think a number of issues could be caught at compile type by adding gradual typing annotations to chipsec. I tried using
pytype
onchipset.py
, but it issues a lot of spurious warnings because it would needTypedDict
annotations to understand the content of the various Cfg arrays (which contain heterogeneous mappings from fixed strings to various types). We could also usemytype
instead, I only tried the one I'm most familiar with.I'd be willing to put in the effort but only if there is a chance to see it merged upstream. Is this something you would be interested in?
The text was updated successfully, but these errors were encountered: