Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect cmake installation instructions fail to install files into the stage directory #3963

Open
yurivict opened this issue Apr 11, 2024 · 0 comments

Comments

@yurivict
Copy link

yurivict commented Apr 11, 2024

In case when installation is done into a stage directory instructions like this fail to install files.

Custom commands can't properly install files.

The reason is that the stage directory is only given to the cmake backend (either GNU make or Ninja) as the DESTDIR environment variable. This value isn't known at the cmake time, so such instructions can't possibly install files into proper destinations under the stage directory.

Proposed solution: Custom commands should build files in the build directory. Then cmake's install commands should be used to install such files into proper destinations under the stage directory.

@yurivict yurivict reopened this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant