Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Rebuild Core Library" appears in the project menu for all projects, not just imported sketches #11

Open
b-perkins opened this issue Mar 14, 2017 · 1 comment
Labels

Comments

@b-perkins
Copy link

After briefly discussing this with Larry it seems like it's pretty minor issue, since selecting rebuild-core-library option in a normal MPLABX project it doesn't appear to do anything harmful (or anything at all).

I just wanted to post it here as a minor issue for future versions.

FYI - this was plugin version 0.9.11 with MPLABX 3.55.07

Thanks,
Brent

gholdys added a commit that referenced this issue Mar 15, 2017
@gholdys
Copy link
Collaborator

gholdys commented Mar 15, 2017

Good catch! The "rebuild core library" action is a so called "context aware action" which means that it should appear only for certain type of projects. The constructor of this action checks the selected project to see if it's root directory contains a "chipKIT-core" directory. Only if this directory exists, the action should be visible. Unfortunately the action was declared as "lazy" which for some reason prevents this mechanism from working properly and the action appears for all projects. I will make this action not lazy and that will fix the problem.
Committed a change to the action class.

@gholdys gholdys added the bug label Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants